Closed Bug 1478504 Opened 6 years ago Closed 6 years ago

DidComposite codepaths should be unified

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Version:
Other Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

Bug 1478504 - Use NotifyPipelineRendered instead of DidComposite for WebRender.
59 bytes, text/x-review-board-request
sotaro
: review+
Details
Bug 1478504 - Inline function only used in a couple of places.
59 bytes, text/x-review-board-request
sotaro
: review+
Details 
There's a couple of different codepaths that get used to send DidComposite notifications from the compositor back to the content side with WR. One is at [1] and the other is at [2] which gets invoked after a pipeline has been rendered.

The first codepath gets invoked from a couple of places and flushes the entire pending transaction id queue which might result in weird side-effects. I'd like to get rid of this codepath and unify everything to the second path for better code clarity.

[1] https://searchfox.org/mozilla-central/rev/943a6cf31a96eb439db8f241ab4df25c14003bb8/gfx/layers/ipc/CompositorBridgeParent.cpp#2209
[2] https://searchfox.org/mozilla-central/rev/943a6cf31a96eb439db8f241ab4df25c14003bb8/gfx/layers/ipc/CompositorBridgeParent.cpp#2172
I wrote the patch for this on top of the patch for bug 1478016. I could rebase it to work without that but for now I'll just make it a dep.
Depends on: 1478016
Comment on attachment 8995255 [details]
Bug 1478504 - Inline function only used in a couple of places.

https://reviewboard.mozilla.org/r/259742/#review266848
Attachment #8995255 - Flags: review?(sotaro.ikeda.g) → review+
Comment on attachment 8995254 [details]
Bug 1478504 - Use NotifyPipelineRendered instead of DidComposite for WebRender.

https://reviewboard.mozilla.org/r/259740/#review266850

Looks good!
Attachment #8995254 - Flags: review?(sotaro.ikeda.g) → review+
^ Those were rebased to not depend on bug 1478016
No longer depends on: 1478016
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3377a2e01e60
Use NotifyPipelineRendered instead of DidComposite for WebRender. r=sotaro
https://hg.mozilla.org/integration/autoland/rev/34a3eff2e575
Inline function only used in a couple of places. r=sotaro
https://hg.mozilla.org/mozilla-central/rev/3377a2e01e60
https://hg.mozilla.org/mozilla-central/rev/34a3eff2e575
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: