Closed Bug 1478517 Opened 6 years ago Closed 4 years ago

The trees tabs are displayed weirdly on Google Chrome

Categories

(Tree Management :: Treeherder: Frontend, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: CosminS, Assigned: shivanshsrivastava2000, Mentored)

Details

(Whiteboard: [lang=js] [good-first-bug])

Attachments

(1 file)

Tested this on Google Chrome Version 67.0.3396.99 and Version 68.0.3440.75. The tabs when having multiple selected repos in Treeherder are displaying in a weird way. This happend for the repos that are not in the active tab. Please see attached screenshot. 

This looks ok on Firefox 61.0.1
Assignee: nobody → cdawson
Component: Treeherder → Treeherder: Frontend
Priority: -- → P3

I can repo this (using Chrome beta 72.0.3626.53).

If it's a bug in Bootstrap it will need to be fixed upstream. However it could also be in the way we customise it too, so leaving this open for now.

I'm not going to get to this anytime soon.

Assignee: cdawson → nobody
Mentor: cdawson
Whiteboard: [lang=js] [good-first-bug]

Those anchor tags in HTML have type="button" This is not valid :-/. Removing that will fix it. Happy to pick this up.

Flags: needinfo?(cdawson)

If this is still open I'd like to give it a go.

(In reply to shavindra from comment #3)

Those anchor tags in HTML have type="button" This is not valid :-/. Removing that will fix it. Happy to pick this up.

Hi Shavindra-- Sure, if you would like to create a pull request for this, that would be much appreciated. Shall I assign this to you?

Flags: needinfo?(cdawson)

Hi Sir , I would like to fix this issue . Please assign this to me , so that I can open a PR.

Assignee: nobody → shivanshsrivastava2000
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Nicely done! :)

Thank You Sir :) .Would like to work on more issues like this .

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: