Closed
Bug 1478547
Opened 7 years ago
Closed 7 years ago
Passwords engine should not handle exceptions adding and updating logins.
Categories
(Firefox :: Sync, enhancement)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
Details
Attachments
(1 file)
via bug 1476480, we discovered that the password engine catches errors applying new passwords. Bad side-effects of this include failure to handle app shutdown, and failure to add the records to the "failed" array, meaning telemetry doesn't record the failure and the record isn't retried on the next sync.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → markh
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•7 years ago
|
||
MozReview-Commit-ID: 3y8ryBxueFS
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8995047 [details]
Bug 1478547 - exceptions processing sync logins now bubble up for better handling and recovery. r?tcsc
Thom Chiovoloni [:tcsc] has approved the revision.
https://phabricator.services.mozilla.com/D2408
Attachment #8995047 -
Flags: review+
Pushed by mhammond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc3f6f7249ed
exceptions processing sync logins now bubble up for better handling and recovery. r=tcsc
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•