Closed
Bug 1478561
Opened 6 years ago
Closed 6 years ago
OOM hooking version choice not rejecting newer rustc versions as it should
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
Details
Attachments
(2 files)
Any build based on the rust-nightly toolchain task probably should have started failing after bug 1471339 due to https://searchfox.org/mozilla-central/rev/943a6cf31a96eb439db8f241ab4df25c14003bb8/toolkit/library/rust/shared/build.rs#15 . I thought the tup build was slipping past due to bug 1478557, but even after that's fixed the script prints cargo:rustc-cfg=feature="oom_with_hook". It looks like the check on line 12 should be for 1.29.0-alpha.
|
||
Comment 1•6 years ago
|
||
> It looks like the check on line 12 should be for 1.29.0-alpha.
Indeed.
|
Assignee | |
Comment 2•6 years ago
|
||
Ok, but we need to start allowing 1.29, what should we be doing there?
|
|
||
Comment 3•6 years ago
|
||
bump to 1.30.0-alpha
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → cmanchester
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
||
Comment 6•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8996149 [details] Bug 1478561 - Bump OOM hook rustc version check to check for greater than 1.30.0-alpha. https://reviewboard.mozilla.org/r/260388/#review267480
Attachment #8996149 -
Flags: review?(mh+mozilla) → review+
|
||
Updated•6 years ago
|
Attachment #8996148 -
Flags: review?(core-build-config-reviews) → review?(nfroyd)
|
|
||
Comment 7•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8996148 [details] Bug 1478561 - Expose MOZ_AUTOMATION to rust running in the tup build. https://reviewboard.mozilla.org/r/260386/#review267532
Attachment #8996148 -
Flags: review?(nfroyd) → review+
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df453510ba55 Expose MOZ_AUTOMATION to rust running in the tup build. r=froydnj https://hg.mozilla.org/integration/autoland/rev/fbca460d249a Bump OOM hook rustc version check to check for greater than 1.30.0-alpha. r=glandium
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/df453510ba55 https://hg.mozilla.org/mozilla-central/rev/fbca460d249a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•