1478580 - Attendee dialog control look like disabled in ESR60 on Windows

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[[:MakeMyDay]]

In the ESR version Lightning 6.2, the listboxes for the attendees list and the freebusy grid have a grey background for Windows - suggesting those wehere disabled. This should be white instead.

For post ESR60, this will be fixed with bug 1477478, so the issue needs an ESR60 only fix.

Richard, can you take a look at it?

Comment 1

[Jorg K (CEST = GMT+2)]

Which panel is that? "Invite Attendees" looks OK to me.

Comment 2

[[:MakeMyDay]]

Attachment: attendee-dialog-ESR52-ESR60b10.png

This is what is see - ESR60b10 is in the foreground, ESR52 for reference in the background. I haven't checked with a new profile though - you don't see the issue?

Comment 3

[Jorg K (CEST = GMT+2)]

Yes, grey background, I didn't notice it.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: attendeeBGColor.patch

Toolkit removed the background color of listboxes because it's not needed when -moz-appearance: listbox; is set. Here the listboxes are -moz-appearance: none;.

Comment 5

[[:MakeMyDay]]

Comment on attachment 8995289 [details] [diff] [review]
attendeeBGColor.patch

Review of attachment 8995289 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the quick fix. Have you verified this isn't an issue on other platforms?

This should only land on ESR but not on CC/beta since bug 1477478 is about to remove the listboxes entirely.

Comment 6

[Richard Marti (:Paenglab)]

I checked all platforms and it's only a Windows issue.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8995289 [details] [diff] [review]
attendeeBGColor.patch

So far beta has the listboxes, so if we do a beta, we will me need this.

Comment 8

[[:MakeMyDay]]

Up to you, but if you land this on beta, you should backout it again with landing bug 1477478 on beta (which should be the plan), so probably it's not worth the effort to land it there.

Comment 9

[Jorg K (CEST = GMT+2)]

Frankly, I don't know what the plans for beta are in general given all the test failures due to the M-C overlay loader still being active. That said, why would uplifting the listbox removal be necessary? What am I missing?

Comment 10

[[:MakeMyDay]]

If there will be no beta for 62, then there is also no point to uplift it to beta in the first place, since uplifting only should happen for release purpose. Calendar is traditionally quite conservative with uplifting (and this is for a reason). But we should keep the discussion about 62 being ready for a beta release out of this bug.

Comment 11

[Jorg K (CEST = GMT+2)]

Sadly you still haven't explained why bug 1477478 is a beta 62 uplift candidate, see "which should be the plan" (comment #8). As far as I can see, it's a pure bustage fix for an M-C feature that got withdrawn at mozilla63, so no uplift required.

This bug here *is* an uplift candidate, since if we build TB 62 beta, we shouldn't regress something that got fixed in TB 60 ESR.

Comment 12

[[:MakeMyDay]]

I don't know for sure, but its at least likely that freebusy lookup will not work, but I haven't tested. Bug 1101381 was just a bandaid patch to at least make adding attendees possible, for anything left not working for 62, bug 1477478 would be the answer.

Comment 13

[Jorg K (CEST = GMT+2)]

The patch works fine:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=666b9d5f84b574db8a6de4737b6ee01e59950fe6

Comment 14

[[:MakeMyDay]]

Thanks for the try push - but if I read it correctly, this is based on mozilla-esr60, which was expected to work. More interestingly would be a try push for 62 once the overlay loader thing is in shape there. If it worked there, too, I would agree with you that there is no need for uplifting bug 1477478.

Comment 15

[Jorg K (CEST = GMT+2)]

I did the try push together with bug 1477641. The state of TB 62 with Calendar 6.4 is for others to assess. As far as I can tell, independent of this small CSS change here, it's mostly not working:
https://treeherder.mozilla.org/#/jobs?repo=comm-beta&revision=11ccbb8139d06af407655115817e50c07f8121ab&selectedJob=190005414
Hard to tell whether the attendee dialogue works. But other things surely fail.

Comment 16

[Jorg K (CEST = GMT+2)]

Just download a build via that link and try it.

Comment 17

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8995289 [details] [diff] [review]
attendeeBGColor.patch

I didn't know -moz-field was case insensitive. Anyway, a+ for whatever you need, I'm certain you will find out where these few lines should best land.

Comment 18

[Richard Marti (:Paenglab)]

checkin-needed for ESR60.

Comment 19

[Jorg K (CEST = GMT+2)]

TB 60 ESR, Cal 6.2:
https://hg.mozilla.org/releases/comm-esr60/rev/e412da29421f