1478605 - Crash due to referring nullptr [@ mozilla::HTMLEditRules::SplitMailCites(bool*)]

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

+++ This bug was initially created as a clone of Bug #1478268 +++

First report is at 2018-07-25 15:45:28:
https://crash-stats.mozilla.com/report/index/0e456519-b44e-48ac-91ff-1c4f60180725

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1478605 - HTMLEditRules::SplitMailCites() should check if split left node has a primary frame before accessing it

The crash at this point may be caused by unexpected behavior change.  However,
it's difficult to investigate what causes the crash.  So, let's just avoid
the crash to investigate what unexpected behavior occurs.

Review commit: https://reviewboard.mozilla.org/r/259614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259614/

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8995136 [details]
Bug 1478605 - HTMLEditRules::SplitMailCites() should check if split left node has a primary frame before accessing it

https://reviewboard.mozilla.org/r/259612/#review266632

Thanks, yes, this works as stated in bug 1478268 comment #18.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8995136 [details]
Bug 1478605 - HTMLEditRules::SplitMailCites() should check if split left node has a primary frame before accessing it

Sorry, I've never used MozReview. I didn't see an r+ button. Now that MozReview is being replaced, I don't think I'll learn it.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Jorg K (GMT+2) from comment #3)
> Comment on attachment 8995136 [details]
> Bug 1478605 - HTMLEditRules::SplitMailCites() should check if split left
> node has a primary frame before accessing it
> 
> Sorry, I've never used MozReview. I didn't see an r+ button. Now that
> MozReview is being replaced, I don't think I'll learn it.

Don't you see "Finish Review" above the page (perhaps, needs login to MozReview)? After push it, dropdown appears which has r+ etc. Marking r+ allows to use Autoland. If you don't see it, I'll land the patch manually.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8995136 [details]
Bug 1478605 - HTMLEditRules::SplitMailCites() should check if split left node has a primary frame before accessing it

https://reviewboard.mozilla.org/r/259614/#review266638

Comment 6

[Jorg K (CEST = GMT+2)]

"Finish Review" didn't show that option before, now it did. Ah well.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63b7b9fbdfad
HTMLEditRules::SplitMailCites() should check if split left node has a primary frame before accessing it r=jorgk+176914

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8995136 [details]
Bug 1478605 - HTMLEditRules::SplitMailCites() should check if split left node has a primary frame before accessing it

And also about this. I'll fix something which you think I should do it in same followup bug.

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/63b7b9fbdfad