Closed
Bug 1478635
Opened 6 years ago
Closed 6 years ago
Remove _createBrowser's 'remote' parameter
Categories
(Firefox :: Tabbed Browser, enhancement, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
(In reply to :Gijs (he/him) from bug 1478618 comment #2) > Comment on attachment 8995150 [details] > Bug 1478618 - Use destructuring assignment for optional _createBrowser > parameters. > > https://reviewboard.mozilla.org/r/259630/#review266662 > > ::: browser/base/content/tabbrowser.js:1806 > (Diff revision 1) > > // remote parameter used by some addons, use default in this case. > > - if (aParams.remote && !aParams.remoteType) { > > + if (remote && !remoteType) { > > Is there a bug on file on removing this?
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=67164bc4b76b3ae2c78cbe48fdc9d95982f02343
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8995545 [details] Bug 1478635 - Remove _createBrowser's 'remote' parameter. https://reviewboard.mozilla.org/r/259946/#review267092
Attachment #8995545 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dd2a9ecb09d8 Remove _createBrowser's 'remote' parameter. r=Gijs
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dd2a9ecb09d8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•