1478713 - Add some tests for the Wasm JS API

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Spec: https://webassembly.github.io/spec/js-api/

Comment 1

[Luke Wagner [:luke]]

Comment on attachment 8995239 [details] [diff] [review]
Patch v1

Review of attachment 8995239 [details] [diff] [review]:
-----------------------------------------------------------------

Overall, looks great, excited to see this really kicking off.  In this early precedent-setting stage, I'd like bbouvier to also have a look and I also reached out to the V8ers to comment.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8995239 [details] [diff] [review]
Patch v1

Review of attachment 8995239 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, only style nits. Thanks.

::: testing/web-platform/meta/wasm/jsapi/interface.any.js.ini
@@ +1,3 @@
> +[interface.any.js]
> +  [WebAssembly.validate]
> +    expected: FAIL

Interesting...

::: testing/web-platform/tests/wasm/jsapi/constructor/instantiate-bad-imports.any.js
@@ +6,5 @@
> +test_bad_imports((name, error, build, ...arguments) => {
> +  promise_test(t => {
> +    const builder = new WasmModuleBuilder();
> +    build(builder);
> +    const buffer = builder.toBuffer()

nit: ; at EOL

@@ +16,5 @@
> +test_bad_imports((name, error, build, ...arguments) => {
> +  promise_test(t => {
> +    const builder = new WasmModuleBuilder();
> +    build(builder);
> +    const buffer = builder.toBuffer()

ditto

::: testing/web-platform/tests/wasm/jsapi/instance/constructor-bad-imports.any.js
@@ +6,5 @@
> +test_bad_imports((name, error, build, ...arguments) => {
> +  test(() => {
> +    const builder = new WasmModuleBuilder();
> +    build(builder);
> +    const buffer = builder.toBuffer()

nit: ; at EOL

::: testing/web-platform/tests/wasm/jsapi/instance/constructor.any.js
@@ +63,5 @@
> +  emptyModuleBinary = new WasmModuleBuilder().toBuffer();
> +});
> +
> +test(() => {
> +  assert_function_name(WebAssembly.Instance, "Instance");

nit: add the description parameter

@@ +67,5 @@
> +  assert_function_name(WebAssembly.Instance, "Instance");
> +}, "name");
> +
> +test(() => {
> +  assert_function_length(WebAssembly.Instance, 1);

nit: add the description parameter

@@ +96,5 @@
> +test(() => {
> +  const builder = new WasmModuleBuilder();
> +  builder.addImportedGlobal("module", "global1", kWasmI32);
> +  builder.addImportedGlobal("module", "global2", kWasmI32);
> +  const buffer = builder.toBuffer()

nit: ; at EOL

::: testing/web-platform/tests/wasm/jsapi/memory/constructor.any.js
@@ +8,5 @@
> +  emptyModuleBinary = new WasmModuleBuilder().toBuffer();
> +});
> +
> +test(() => {
> +  assert_function_name(WebAssembly.Memory, "Memory");

nit: add the description parameter

@@ +12,5 @@
> +  assert_function_name(WebAssembly.Memory, "Memory");
> +}, "name");
> +
> +test(() => {
> +  assert_function_length(WebAssembly.Memory, 1);

nit: add the description parameter

::: testing/web-platform/tests/wasm/jsapi/module/constructor.any.js
@@ +8,5 @@
> +  emptyModuleBinary = new WasmModuleBuilder().toBuffer();
> +});
> +
> +test(() => {
> +  assert_function_name(WebAssembly.Module, "Module");

nit: add the description parameter

@@ +12,5 @@
> +  assert_function_name(WebAssembly.Module, "Module");
> +}, "name");
> +
> +test(() => {
> +  assert_function_length(WebAssembly.Module, 1);

nit: add the description parameter

::: testing/web-platform/tests/wasm/jsapi/table/constructor.any.js
@@ +8,5 @@
> +  emptyModuleBinary = new WasmModuleBuilder().toBuffer();
> +});
> +
> +test(() => {
> +  assert_function_name(WebAssembly.Table, "Table");

nit: add the description parameter

@@ +12,5 @@
> +  assert_function_name(WebAssembly.Table, "Table");
> +}, "name");
> +
> +test(() => {
> +  assert_function_length(WebAssembly.Table, 1);

nit: add the description parameter

Comment 3

[Luke Wagner [:luke]]

(Btw, the V8 Bens said lgtm, so land whenever you're ready)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed655b513685
Add some tests for the Wasm JS API; r=luke+bbouvier

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12334 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ed655b513685

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged