1478735 - Download with target=_blank switches to other tab target=_blank

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: tabs_example.zip

Using the attached example in fennec:

1. Open index.html
2. Tap the first link ("index.html"), which opens in a new tab
3. Switch back to the first tab
4. Tap the second link ("blah.wav"). A new tab briefly opens and disappears, then we switch to the second tab. Meanwhile the prompt for what to do with the download is in the first tab.

This doesn't seem to happen if I simply have another tab open, the second tab has to be _blank.

I tried to do a mozregression bisection on this but I wasn't able to find a build where we don't switch to the second tab. I did find that earlier in 2017 the "what to do with this download" prompt at least shows up, instead of showing up on the wrong tab, the range for this was:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ef813898b5d34ef03428b1cee37a329f425db6e7&tochange=9e45f48ecf55f1d184834bb287411c17bb635a95

But that probably doesn't need to be fixed, if we properly switched back to the first tab the prompt would be visible.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Jim seems to be a regression from work about a year ago. Any thoughts if this is a simple thing to address?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

I think someone from Susheel's team should take a look. Since it's reproducible I don't think it'll take too long

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Comment 1 and 2

Comment 4

[:sdaswani]

Put it on the work queue.

Comment 5

[Vlad Baicu]

Fwiw, while testing I noticed that Fennec is not shown as an option when opening .html files from the device, but Chrome is, you have to put the path to the file to access it e.g. file:///sdcard/Download/index.html.

Based on the findings of our QA team, it seems to be the issue reported here https://bugzilla.mozilla.org/show_bug.cgi?id=1375035

Comment 6

[Andrei Lazar]

Attachment: Bug 1478735 Download with target=_blank switches to other tab target=_blank r=sdaswani

Download with target=_blank now switches to the parent tab.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a42437c2e1fe
Download with target=_blank switches to other tab target=_blank r=JanH,jchen

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out changeset a42437c2e1fe (Bug 1478735) for failures in mobile/android/tests/browser/chrome/test_session_parentid.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success,testfailed,busted,exception&searchStr=9317f44ffd06849ff27e002bdb18b0ae3effcc8c&revision=a42437c2e1fe656e5573c7951c1d50298d8a2f45&selectedJob=203135077

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=203135077&repo=autoland&lineNumber=1875

Backout: https://hg.mozilla.org/integration/autoland/rev/bde685714bea04e95e8fc69e4da2cd51039d3bcd

Comment 9

[Cosmin Sabou [:CosminS]]

As per this comment https://phabricator.services.mozilla.com/D6928#185569 this needs some modifications before landing. Removing the chechin-needed.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9dfaf584e37
Download with target=_blank switches to other tab target=_blank r=JanH,jchen

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e9dfaf584e37