1478739 - Non ES5 code in HCT lib is breaking uglify builds

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Stuart Colville [:muffinresearch]]

Having submitted a PR for the implementation of HCT on the disco pane our bundle builds are breaking due to ES6 code in the lib.

Typically most packages publish ES code. 

We can also look to update to uglify-es but this might slow down the implementation because it has other dependencies.

To make the HCT lib uglifyable you can simply:

* Remove arrow functions 52
* Remove object shorthands 37, 81, 85

Alternatively transpile the library as part of the build process.

Comment 1

[Stuart Colville [:muffinresearch]]

This line:

Typically most packages publish ES code. 

Should be:

Typically most packages publish ES5 code.

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1478739 - Don't use object shorthands and arrow functions in HCT.

Comment 3

[Phabricator Automation]

Comment on attachment 8995962 [details]
Bug 1478739 - Don't use object shorthands and arrow functions in HCT.

Chris H-C :chutten has approved the revision.

https://phabricator.services.mozilla.com/D2508

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/802725c77093
Don't use object shorthands and arrow functions in HCT. r=chutten

Comment 5

[Jan-Erik Rediger [:janerik]]

This is landing now. We will need to wait for :dexter to come back and push an NPM release (I'll make sure to get npm access afterwards for me and the team as well)

Comment 6

[Jan-Erik Rediger [:janerik]]

I got access and published Version 1.1.1[1]

[1]: https://www.npmjs.com/package/mozilla-hybrid-content-telemetry

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/802725c77093