Closed Bug 147877 Opened 22 years ago Closed 22 years ago

Add pref to disable plugins while displaying message

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Platform:
All
Windows 2000
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

(Keywords: topembed, Whiteboard: [ADT1 RTM] Have a solution.,custrtm-)

Attachments

(3 files)

Proposed fix, v2 (no UI)
4.36 KB, patch
bugzilla
: review+
bugzilla
: superreview+
chofmann
: approval+
Details | Diff | Splinter Review
Proposed fix, v3 (UI only)
7.06 KB, patch
bugzilla
: review+
mscott
: superreview+
jud
: approval+
Details | Diff | Splinter Review
String changes required for the UI
2.73 KB, patch
bugzilla
: review+
bugzilla
: superreview+
Details | Diff | Splinter Review 
This is a mirror of bugscape 11669. We nee to add a pref to disable plugins in
mail display. For now only an hidden pref...UI coming later.
moving over status and keyword (nomination)
Status: NEW → ASSIGNED
Keywords: adt1.0.0+, nsbeta1+, topembed-
Whiteboard: [ADT1 RTM] Have a solution.,custrtm-
This is only the backend part to support a pref named
"mailnews.message_display.allow.plugins". I still need to do the UI but if you
want to give a try, just define the pref mailnews.message_display.allow.plugins

to false in your prefs.js file...
Comment on attachment 85446 [details] [diff] [review]
Proposed fix, v2 (no UI)

R=mscott
SR=bienvenu
Attachment #85446 - Flags: superreview+
Attachment #85446 - Flags: review+
The patch has been checked in the trunk on 2002-04-22.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
QA Contact: olgam → carosendahl
Resolution: --- → FIXED
Charles Rosendahl 2002-05-28 17:19:
Verified on the trunk using the 052304 build.  Do with the current fix as you may.
Status: RESOLVED → VERIFIED
nominating adt1.0.1
Keywords: adt1.0.1
changing to adt1.0.1+
Keywords: adt1.0.0+, adt1.0.1 → adt1.0.1+
Keywords: mozilla1.0.1
Comment on attachment 85446 [details] [diff] [review]
Proposed fix, v2 (no UI)

a=chofmann for 1.0.1
Attachment #85446 - Flags: approval+
Keywords: mozilla1.0.1 → mozilla1.0.1+
I have the whole UI changes ready in my tree and I am curently seeking reviews.
But has the UI freeze is for tonight, I need to check in asap the string
changes in the branch.
Looks like the following text changes:
1. Remove Header "Scripts & Windows" and replaces with Header "Scripts & 
Plugins"
2. Removes "Enable JavaScript for:" and replaces with "Enable JavaScript for"
3. Add "Enable Plugins for" group box header
4. Add "Mail & Newsgroups" checkbox text

Looks good.
Comment on attachment 86138 [details] [diff] [review]
Proposed fix, v3 (UI only)

R=glick
Attachment #86138 - Flags: review+
I mean jglick (sorry)
Comment on attachment 86138 [details] [diff] [review]
Proposed fix, v3 (UI only)

sr=mscott
Attachment #86138 - Flags: superreview+
+    <!-- mailnews will add it's checkbox here using overlay (mailPrefOverlay.xul).
 this should be "its"
other than that, sr=bienvenu
oops, I have attached the whole patch instead of only the dtd changes!
I have checked in the backend part of this feature in the branch (fix v2)
Keywords: topembed- → topembed
Comment on attachment 86138 [details] [diff] [review]
Proposed fix, v3 (UI only)

R=bhuvan (from bugscape)
Attachment #86138 - Attachment description: Strings changes require for implementing the UI → Proposed fix, v3 (UI only)
This patch contains only the string changes required for the UI.
Comment on attachment 86162 [details] [diff] [review]
String changes required for the UI

r=jglick
sr=mscott
Attachment #86162 - Flags: superreview+
Attachment #86162 - Flags: review+
UI fixed in the trunk.
QA, can you verify the UI in the next trunk build. See screen shot in bugscape
11669 for the new UI. Thanks
l10n approved. Please check it into the branch ASAP.
Verified on 2002060508 Trunk builds Linux, Win2k, and Mac OSX.

When the pref is disabled macromedia/quicktime plugins are not displayed.

When the pref is enabled, the plugins appear.
Comment 22 was me, not Bindu.
Attachment #86138 - Flags: approval+
Fix (UI) checked in the branch
Keywords: mozilla1.0.1+ → fixed1.0.1
charles - can you pls verify that this has been fixed on the 1.0 branch, then
replace fixed1.0.1 with verified1.0.1.
Verified on 6/18 and 6/19 branch builds using macromedia and quicktime plugins.
Keywords: fixed1.0.1 → verified1.0.1
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: