1478800 - SessionFinder display flags do not seem to work

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Emily Kager [:ekager]]

When using the find in page API in Focus, I am setting the display flags like this (Kotlin), but they don't seem to do anything:
finder.displayFlags = GeckoSession.FINDER_DISPLAY_HIGHLIGHT_ALL

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1478800 - Fix find-in-page display flags;

Make the display flags actually work.

Review commit: https://reviewboard.mozilla.org/r/259798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259798/

Comment 2

[Chris Peterson [:cpeterson]]

P1 because we want find-in-page support in Focus 7.0.

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8995341 [details]
Bug 1478800 - Fix find-in-page display flags;

https://reviewboard.mozilla.org/r/259798/#review267078

LGTM

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4280f25a471
Fix find-in-page display flags; r=droeh

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a4280f25a471

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8995341 [details]
Bug 1478800 - Fix find-in-page display flags;

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1463484
[User impact if declined]: Cannot set find-in-page display flags under GeckoView
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: GeckoView-only fix for find-in-page feature.
[String changes made/needed]: None

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8995341 [details]
Bug 1478800 - Fix find-in-page display flags;

GeckoView related, Beta62+

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/cdb16820b53e