Closed Bug 1478800 Opened 2 years ago Closed 2 years ago
Finder display flags do not seem to work
When using the find in page API in Focus, I am setting the display flags like this (Kotlin), but they don't seem to do anything: finder.displayFlags = GeckoSession.FINDER_DISPLAY_HIGHLIGHT_ALL
Assignee: nobody → nchen
Status: NEW → ASSIGNED
P1 because we want find-in-page support in Focus 7.0.
Comment on attachment 8995341 [details] Bug 1478800 - Fix find-in-page display flags; https://reviewboard.mozilla.org/r/259798/#review267078 LGTM
Attachment #8995341 - Flags: review?(droeh) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/a4280f25a471 Fix find-in-page display flags; r=droeh
Comment on attachment 8995341 [details] Bug 1478800 - Fix find-in-page display flags; Approval Request Comment [Feature/Bug causing the regression]: Bug 1463484 [User impact if declined]: Cannot set find-in-page display flags under GeckoView [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: GeckoView-only fix for find-in-page feature. [String changes made/needed]: None
Attachment #8995341 - Flags: approval-mozilla-beta?
Comment on attachment 8995341 [details] Bug 1478800 - Fix find-in-page display flags; GeckoView related, Beta62+
Attachment #8995341 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.