1478819 - Doorhanger menu should have title case capitalization

Status: VERIFIED FIXED

(DevTools :: General, defect, P3)

Description

[Victoria Wang [:victoria]]

More info: https://design.firefox.com/photon/copy/capitalization.html#platform-styles

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

For my own reference, Localization content best practices[1] says:

  "If your changes are relevant only for English — for example, to correct a typographical error or to make letter case consistent — then there is generally no need to update the entity name."

So it seems like we don't need to rev the string IDs for this. (Although it might be nice to invalidate, say, German, but not Japanese.)

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(I should probably fix bug 1473211 first, however, and I'm not sure how well glob's review submission tool works for interdependent patches so I might have to land that first.)

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1478819 - Make Meatball Menu items use title case; r?jdescottes

As per: https://design.firefox.com/photon/copy/capitalization.html#platform-styles

Comment 4

[Phabricator Automation]

Comment on attachment 8996600 [details]
Bug 1478819 - Make Meatball Menu items use title case; r?jdescottes

Francesco Lodolo [:flod] has approved the revision.

https://phabricator.services.mozilla.com/D2591

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Thanks Francesco!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60b1a28da655
Make Meatball Menu items use title case; r=flod

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/60b1a28da655

Comment 8

[Emil Ghitta, QA [:emilghitta]]

This is verified fixed using Firefox 63.0b7 (BuildId:20180917143811) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 16.04 64bit.