Add an explanatory comment to HashName()

RESOLVED FIXED in Firefox 63

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

It's exactly equivalent to HashString() from nsHashKeys.h, which is already
used elsewhere within ActorsParent.cpp. (I checked equivalence by code
inspection and also by printing the values produced at runtime for both.)
Attachment #8995391 - Flags: review?(jvarga)
We should have added a comment for this. Feel free to do that.
See bug 940315 and bug 780408.
Attachment #8995391 - Attachment is obsolete: true
Attachment #8995391 - Flags: review?(jvarga)
Comment on attachment 8995426 [details] [diff] [review]
Add an explanatory comment to HashName()

Review of attachment 8995426 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #8995426 - Flags: review?(jvarga) → review+
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6910c4247072
Add an explanatory comment to HashName(). r=janv
Summary: Remove HashName() from ActorsParent.cpp → Add an explanatory comment to HashName()
https://hg.mozilla.org/mozilla-central/rev/6910c4247072
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.