Closed
Bug 1478895
Opened 6 years ago
Closed 6 years ago
Add an explanatory comment to HashName()
Categories
(Core :: Storage: IndexedDB, enhancement)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file, 1 obsolete file)
|
1.64 KB,
patch
|
janv
:
review+
|
Details | Diff | Splinter Review |
It's exactly equivalent to HashString() from nsHashKeys.h, which is already used elsewhere within ActorsParent.cpp. (I checked equivalence by code inspection and also by printing the values produced at runtime for both.)
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8995391 -
Flags: review?(jvarga)
|
||
Comment 2•6 years ago
|
||
We should have added a comment for this. Feel free to do that. See bug 940315 and bug 780408.
|
|
Assignee | |
Comment 3•6 years ago
|
||
Attachment #8995426 -
Flags: review?(jvarga)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8995391 -
Attachment is obsolete: true
Attachment #8995391 -
Flags: review?(jvarga)
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8995426 [details] [diff] [review] Add an explanatory comment to HashName() Review of attachment 8995426 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8995426 -
Flags: review?(jvarga) → review+
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6910c4247072 Add an explanatory comment to HashName(). r=janv
|
|
Assignee | |
Updated•6 years ago
|
Summary: Remove HashName() from ActorsParent.cpp → Add an explanatory comment to HashName()
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6910c4247072
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•