Don't disable PGO for the js shell in clang-cl

RESOLVED FIXED in Firefox 63

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: dmajor, Assigned: dmajor)

Tracking

Trunk
mozilla63
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

clang-cl builds hit unresolved externals for __llvm_profile_... functions, because the NO_PGO in js/src/shell/moz.build prevents js.exe from linking against  clang_rt.profile-x86_64.lib.

Since all the JS object files have been PGO'd anyway (for the sake of the primary build in libxul), we might as well let the shell do PGO.
Assignee: nobody → dmajor
Attachment #8995403 - Flags: review?(core-build-config-reviews)
Comment on attachment 8995403 [details] [diff] [review]
Bug 1478903 - Don't disable PGO for the js shell in clang-cl

Review of attachment 8995403 [details] [diff] [review]:
-----------------------------------------------------------------

Seems unfortunate, but such is life.
Attachment #8995403 - Flags: review?(core-build-config-reviews) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17d02fcdf8d5
Don't disable PGO for the js shell in clang-cl. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/17d02fcdf8d5
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
The primary reason we didn't do this for MSVC is because MSVC's LTO takes so long. Presumably even with LTO in clang this will not be so bad.
You need to log in before you can comment on or make changes to this bug.