Closed
Bug 1478903
Opened 7 years ago
Closed 7 years ago
Don't disable PGO for the js shell in clang-cl
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
1.05 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
clang-cl builds hit unresolved externals for __llvm_profile_... functions, because the NO_PGO in js/src/shell/moz.build prevents js.exe from linking against clang_rt.profile-x86_64.lib.
Since all the JS object files have been PGO'd anyway (for the sake of the primary build in libxul), we might as well let the shell do PGO.
Assignee: nobody → dmajor
Attachment #8995403 -
Flags: review?(core-build-config-reviews)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8995403 [details] [diff] [review]
Bug 1478903 - Don't disable PGO for the js shell in clang-cl
Review of attachment 8995403 [details] [diff] [review]:
-----------------------------------------------------------------
Seems unfortunate, but such is life.
Attachment #8995403 -
Flags: review?(core-build-config-reviews) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17d02fcdf8d5
Don't disable PGO for the js shell in clang-cl. r=froydnj
|
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Comment 5•7 years ago
|
||
The primary reason we didn't do this for MSVC is because MSVC's LTO takes so long. Presumably even with LTO in clang this will not be so bad.
You need to log in
before you can comment on or make changes to this bug.
Description
•