Closed Bug 1478909 Opened Last year Closed Last year

funcName should be implicit

Categories

(Core :: Canvas: WebGL, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

Right now we pass funcName through the call tree. Since we can only be servicing one root webgl function call at once, we should make funcName implicit and globally queryable.
This also asserts if ScopedFuncInfo leaves scope without having IsContextLost checked.
This patch notably adds asserts in ErrorInvalid*() that we have a valid mFuncInfo, as well.
Comment on attachment 8997264 [details]
Make funcName implicit for WebGL calls.

Dzmitry Malyshau [:kvark] has approved the revision.

https://phabricator.services.mozilla.com/D2697
Attachment #8997264 - Flags: review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8023a02b6c2
Make funcName implicit for WebGL calls. - r=kvark
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b807f63147ae
Make funcName implicit for WebGL calls. - r=kvark
https://hg.mozilla.org/mozilla-central/rev/b807f63147ae
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Depends on: 1535373
Flags: needinfo?(jgilbert)
No longer depends on: 1535373
Regressions: 1535373
You need to log in before you can comment on or make changes to this bug.