1478909 - funcName should be implicit

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P3)

Description

[Kelsey Gilbert [:jgilbert]]

Right now we pass funcName through the call tree. Since we can only be servicing one root webgl function call at once, we should make funcName implicit and globally queryable.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Make funcName implicit for WebGL calls.

This also asserts if ScopedFuncInfo leaves scope without having IsContextLost checked.
This patch notably adds asserts in ErrorInvalid*() that we have a valid mFuncInfo, as well.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ccd62f007f159ed44776380d18123014b67b5b7

Comment 3

[Phabricator Automation]

Comment on attachment 8997264 [details]
Make funcName implicit for WebGL calls.

Dzmitry Malyshau [:kvark] has approved the revision.

https://phabricator.services.mozilla.com/D2697

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8023a02b6c2
Make funcName implicit for WebGL calls. - r=kvark

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset e8023a02b6c2 (bug 1478909) on dev's request

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=192896636&repo=mozilla-inbound


Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e8023a02b6c2870e15bea85539ce9ba1563ffdc5

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c50b638b8e7157661ce4ebb023c93969844eddbf

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b807f63147ae
Make funcName implicit for WebGL calls. - r=kvark

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/b807f63147ae