Closed Bug 1478922 Opened 2 years ago Closed 2 years ago

Stage bookmark tags to upload in a separate table instead of using a subquery

Categories

(Firefox :: Sync, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: lina, Assigned: lina)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Speaking of tags...testing with a profile containing ~40k bookmarks, removing this funky `GROUP_CONCAT` subquery brought the transaction time down from 10s to 4s. Not a typical case, but seems like an obvious quick win that we should do it. I think it also makes the query more readable. :-)
The current tags work is mostly trying to move the tagging API to Bookmarks.jsm, that will unblock WebExtensions usage and allow us to remove all the main-thread APIs. The following step will actually change the schema, and it will solve some of these inefficient queries. Hopefully we can be at that point before EOY.
Comment on attachment 8995430 [details]
Stage bookmark tags to upload in a separate table instead of using a subquery.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2455
Attachment #8995430 - Flags: review+
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/407712756e4d
Stage bookmark tags to upload in a separate table instead of using a subquery. r=mak
https://hg.mozilla.org/mozilla-central/rev/407712756e4d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.