1478937 - Incomplete spotlight for about:preferences#privacy-permissions

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: [e-mail]

[Description:]
 When sent to about:preferences#privacy from block auto-play preferences settings, the spotlight doesn't cover the block auto-play section.   


[Pre-requisites:] (default in Nightly 63)
media.autoplay.ask-permission = true
media.autoplay.default = 2
media.autoplay.enabled.user-gestures-needed = true

[Environments:]
Ubuntu 16.04 x64, Windows 10 x64, Osx 10.13
63.0a1 2018-07-27

[Steps:]
1. Open Firefox.
2. In the address bar paste: https://www.youtube.com/watch?v=a094Osdrxgg
3. In the Autoplay block privacy pop-up choose any option: block, allow (temporary allow/block is fine too)
4. Click on the (i) icon(Site information) and then on in the Permissions section, click on the wheel icon (Open Permissions Preferences) 

[Actual Result:]
about:preferences#privacy (about:preferences#privacy-permissions) is opened but half of it is not spotlighted, hence for the above test case, making the block autoplay options and exception not intuitive to find. (see attached screenshot)

[Expected Result:]
The entire Permissions sections is spotlighted when redirected from about:preferences#privacy-permissions


[Notes:]
1. It might be that there is a duplicate after this bug somewhere in bugzilla, but couldn't find it: - please dupe-me if I missed it.
2. Not sure how this issue applies to the other channels.
3. Block auto-play version targets Nightly 63, but I'm not sure if there are other features affected by the spotlight (other redirects exist to about:preferences#privacy-permissions) : might be done so by design and then block auto-play sections is not well positioned.

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: 0001-Bug-1478937-Highlight-whole-permissions-section.-r-j.patch

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 9001931 [details] [diff] [review]
0001-Bug-1478937-Highlight-whole-permissions-section.-r-j.patch

Review of attachment 9001931 [details] [diff] [review]:
-----------------------------------------------------------------

I suppose this works, note that IMO the blue highlight should either include the "Permissions" header or have a bit better padding to it, but that's only a nit.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad8cb6446de2
Highlight whole permissions section. r=johannh

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ad8cb6446de2

Comment 5

[Gyula Palko[:gpalko]]

Verified, that the issue is no longer reproducible on Nightly 63.0a1(20180821100053).