1479006 - Move client/shared/widgets/tooltip/Tooltip to the debugger folder

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement)

Description

[Julian Descottes [:jdescottes]]

After Bug 1307464, the old debugger is now the only consumer of the old tooltip widget and we can move the implementation and the CSS in the debugger folder to avoid polluting our shared widgets folder.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1479006 - Move old devtools tooltip widget to debugger folder;

Review commit: https://reviewboard.mozilla.org/r/259936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259936/

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1479006 - Remove CSS rules for deleted netmonitor tooltips;

Review commit: https://reviewboard.mozilla.org/r/259938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259938/

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8995534 [details]
Bug 1479006 - Move old devtools tooltip widget to debugger folder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259936/diff/1-2/

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8995535 [details]
Bug 1479006 - Remove CSS rules for deleted netmonitor tooltips;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259938/diff/1-2/

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8995534 [details]
Bug 1479006 - Move old devtools tooltip widget to debugger folder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259936/diff/2-3/

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8995535 [details]
Bug 1479006 - Remove CSS rules for deleted netmonitor tooltips;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259938/diff/2-3/

Comment 7

[Julian Descottes [:jdescottes]]

Tests passed locally :) Let's see if try agrees: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae53cc2e2c007745d01a50ba0d27a251d46f0e80

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8995534 [details]
Bug 1479006 - Move old devtools tooltip widget to debugger folder;

https://reviewboard.mozilla.org/r/259936/#review267032

Looks good to me (I trust your local testing and TRY :D )

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8995535 [details]
Bug 1479006 - Remove CSS rules for deleted netmonitor tooltips;

https://reviewboard.mozilla.org/r/259938/#review267036

From the quick testing I made this seems safe.
Thanks for the cleanup Julian

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2815e6fce739
Move old devtools tooltip widget to debugger folder;r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8a1379826329
Remove CSS rules for deleted netmonitor tooltips;r=nchevobbe

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2815e6fce739
https://hg.mozilla.org/mozilla-central/rev/8a1379826329