Closed Bug 1479036 Opened 2 years ago Closed 2 years ago

Add android class names to RoleMap.h

Categories

(Core :: Disability Access APIs, enhancement)

Unspecified
Android
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file, 1 obsolete file)

In Android there are no real roles. But we do need to spoof android class names. We need a mapping from gecko roles to Android classes.
Blocks: 1479037
Attachment #8996424 - Flags: review?(surkov.alexander)
Comment on attachment 8996424 [details] [diff] [review]
Android classes role additions. r?surkov

Review of attachment 8996424 [details] [diff] [review]:
-----------------------------------------------------------------

any examples of usage? will it be in follow-up bugs?
Eitan, ping ^
Flags: needinfo?(eitan)
Comment on attachment 8996424 [details] [diff] [review]
Android classes role additions. r?surkov

Review of attachment 8996424 [details] [diff] [review]:
-----------------------------------------------------------------

I don't have concerns about the code, but ultimately I don't have a big picture of all ongoing changes. So I'm going to r+ since I don't have code concerns, but seeking for more details for sure.
Attachment #8996424 - Flags: review?(surkov.alexander) → review+
I use RoleMap.h in Android just like in other platforms: include the header in-line and redefine the ROLE macro. The classnames are used in the platform accessible objects. They really just arbitrary strings that have meaning in Android accessibility. They aren't actual classes we use, or anything like that.
Flags: needinfo?(eitan)
Attachment #8996424 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a51d4fba8a5
Android classes role additions. r=surkov
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2a51d4fba8a5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.