1479049 - TB 60 ESR build claims: You are currently on the beta update channel

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Jorg K (CEST = GMT+2)]

As discussed on tb-drivers. Tom said:

it is probably incorrect mozconfig or branch specific mozharness config.

Comment 1

[Jorg K (CEST = GMT+2)]

Rob, could you take a look, according to Tom (via IRC) this shouldn't be too hard.

Comment 2

[Wayne Mery (:wsmwk)]

This is actually a blocker, so quite important short term requirement

Comment 3

[Rob Lemley [:rjl]]

Attachment: bug1479049-v1.diff

I wasn't sure what the channel name should be, so I went with "release".

Comment 4

[Jorg K (CEST = GMT+2)]

Amazing, in all that build stuff, you found the spot that looks right ;-) - I think "release" is right.

Comment 5

[Tom Prince [:tomprince]]

Comment on attachment 8995859 [details] [diff] [review]
bug1479049-v1.diff

This looks good, as far as it goes. However, it is often useful to grep around to see where else things get set. I discovered https://hg.mozilla.org/releases/comm-esr60/file/tip/mozharness/single_locale/comm-esr60.py#l11 which it looks like I also set incorrectly.

Comment 6

[Rob Lemley [:rjl]]

Attachment: bug1479049-v2.diff (for ESR only)

Updated patch per Tom's comment.

I did some more grepping, but didn't see any other obvious changes that need to be made.

Comment 7

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/comm-esr60/rev/1ca370640e14dae17f889d5bd75ca4619bf1cf8d
Fix update channel for ESR builds. r=tomprince a=jorgk

Comment 8

[Tom Prince [:tomprince]]

This should land on c-c too.

Comment 9

[Jorg K (CEST = GMT+2)]

Patch doesn't apply at all. No file mozharness/single_locale/comm-esr60.py and the hunk in mozharness/builds/branch_specifics.py fails since there is no config for comm-esr60.

I'll let you build/release guys work out what you want to do.

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 8996159 [details] [diff] [review]
bug1479049-v2.diff (for ESR only)

In fact, I tried applying the patch to C-C. In the end I thought, ESR60 configuration in C-C is not completely useful since when C-C gets merged to ESR again, we'll be at 68 and comm-esr60.py won't help us. Adding a section to branch_specifics.py won't hurt, I suppose.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cb643fc4afab
Fix update channel for ESR builds. r=tomprince

Comment 12

[Tom Prince [:tomprince]]

Even if we don't need the *esr60* configs when we branch for 68, having them in the tree will make figuring out what changes are needed for *esr68* easier.