Closed Bug 1479054 Opened 3 years ago Closed 3 years ago
[wpt-sync] Sync PR 12215 - Find Layout
Text containing the first letter before attaching pseudo .
Sync web-platform-tests PR 12215 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/12215 Details from upstream follow. Rune Lillesveen <email@example.com> wrote: > Find LayoutText containing the first letter before attaching pseudo. > > We assert that we find the same text node before creating the element as > we find when attaching the first letter LayoutText. We used to attach > the ::first-letter pseudo element before finding the LayoutText from > which we get the first letter text. > > We did crash in a clusterfuzz test because FirstLetterTextLayoutObject() > was confused by a combination of a grid, button, anonymous > wrappers and continuations. Instead of trying to fix all bugs in > FirstLetterTextLayoutObject(), find the LayoutText before attaching the > ::first-letter to make sure we are consistent instead of chasing > clusterfuzz issues. > > Reported the incorrectness for button, grid, and ::first-letter in > 868380. > > Bug: 859285, 868380 > Change-Id: I335a32b466ab31858fb05ea5f650cf12ab674040 > > Reviewed-on: https://chromium-review.googlesource.com/1152982 > WPT-Export-Revision: b99cb2fb8f82732605dccc213ef66d6d506d1923
3 years ago
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d3f785d4abd65ced13ee0f5c213120c49d60ca7
Ran 1 tests PASS : 1
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f1059b2442f3313f6d6c982c60e788807b9499b
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/ce77e99e9815 [wpt PR 12215] - Find LayoutText containing the first letter before attaching pseudo., a=testonly
You need to log in before you can comment on or make changes to this bug.