Closed Bug 1479054 Opened 8 years ago Closed 8 years ago

[wpt-sync] Sync PR 12215 - Find LayoutText containing the first letter before attaching pseudo.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12215 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/12215 Details from upstream follow. Rune Lillesveen <futhark@chromium.org> wrote: > Find LayoutText containing the first letter before attaching pseudo. > > We assert that we find the same text node before creating the element as > we find when attaching the first letter LayoutText. We used to attach > the ::first-letter pseudo element before finding the LayoutText from > which we get the first letter text. > > We did crash in a clusterfuzz test because FirstLetterTextLayoutObject() > was confused by a combination of a grid, button, anonymous > wrappers and continuations. Instead of trying to fix all bugs in > FirstLetterTextLayoutObject(), find the LayoutText before attaching the > ::first-letter to make sure we are consistent instead of chasing > clusterfuzz issues. > > Reported the incorrectness for button, grid, and ::first-letter in > 868380. > > Bug: 859285, 868380 > Change-Id: I335a32b466ab31858fb05ea5f650cf12ab674040 > > Reviewed-on: https://chromium-review.googlesource.com/1152982 > WPT-Export-Revision: b99cb2fb8f82732605dccc213ef66d6d506d1923
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ce77e99e9815 [wpt PR 12215] - Find LayoutText containing the first letter before attaching pseudo., a=testonly
https://hg.mozilla.org/mozilla-central/rev/ce77e99e9815
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.