Closed Bug 1479071 Opened Last year Closed Last year

Changes to the paper size made in Page Setup do not persist, not reflected in print dialog

Categories

(Core :: Printing: Setup, defect, P3)

63 Branch
Unspecified
macOS
defect

Tracking

()

VERIFIED FIXED
mozilla63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- verified
firefox61 --- wontfix
firefox62 --- verified
firefox63 --- verified

People

(Reporter: haik, Assigned: mantaroh)

References

Details

(Keywords: regression)

Attachments

(1 file)

On macOS, changing the default paper size in page setup is not remember when the print dialog is displayed. Mozregression indicated bug 1411879 introduced this problem.

$ mozregression --good 2017-02-01
...
19:07.42 INFO: No more inbound revisions, bisection finished.
19:07.42 INFO: Last good revision: 2b51a6cf8f4c25baa87d90e98646868615e8273d
19:07.42 INFO: First bad revision: 9089083929039ac0dddc5707525b73e9922edef8
19:07.42 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b51a6cf8f4c25baa87d90e98646868615e8273d&tochange=9089083929039ac0dddc5707525b73e9922edef8
Blocks: 1411879
Flags: needinfo?(mantaroh)
See Also: → 1319116
Blocks: 1319116
I hit this bug on macOS 10.13.6 and have not tested other OS versions.
Thanks, Haik.

I confirmed that kPMDataFormatXMLDefault and kPMDataFormatXMLMinimum works fine, however, kPMDataFormatXMLCompress doesn't work. In any case, I'll look into this behavior in more detail.
Priority: -- → P3
I investigated this phenomenon.
I can reproduce this bug when setting the specific paper size. (e.g., In japanese environment, paper size setting saved "A4"/"B4". However, "Letter"  size doesn't saved.

I tried to specify the kPMDataFormatXMLMinimal.
This change worked well.:
https://hg.mozilla.org/try/rev/4dd043a6f859934875cbf14acc7b23496cbafc46
Sorry for my late reply.

Some parameter works correctly. However, as mentioned in comment 3, some combination of print settings can't store print information. I don't know this reason yet. I would like to revert this parameter to kPMDataFormatXMLNormal until making clear this reason.

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=98fa389cc9b48a9034cbadb0c8c87a2579bac6fc
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
Bug 1411879 introduced kPMDataFormatXMLCompress. However, this parameter caused
the saving print settings problem.
Before investigating this reason, this patch will revert this parameter.
Comment on attachment 9003002 [details]
Bug 1479071 - Revert kPMDataFormatXMLCompressed to kPMDataFormatXMLNormal. r=mstange

Markus Stange [:mstange] has approved the revision.
Attachment #9003002 - Flags: review+
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/69fdbbb5facc
Revert kPMDataFormatXMLCompressed to kPMDataFormatXMLNormal. r=mstange
Flags: needinfo?(mantaroh)
https://hg.mozilla.org/mozilla-central/rev/69fdbbb5facc
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
This will bit ESR users migrating from 52 to 60 next month. What do you think about nominating this for Beta/ESR60 backport?
Flags: needinfo?(mantaroh)
Comment on attachment 9003002 [details]
Bug 1479071 - Revert kPMDataFormatXMLCompressed to kPMDataFormatXMLNormal. r=mstange

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)
> This will bit ESR users migrating from 52 to 60 next month. What do you
> think about nominating this for Beta/ESR60 backport?

Yes. We should uplift this patch. This is the approval request.

Beta: Approval Request Comment
[Feature/Bug causing the regression]: bug 1411879
[User impact if declined]: Some of the combinations of print settings will not be saved.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: Extremely low
[Why is the change risky/not risky?]: This change is just reverting the regression.
[String changes made/needed]: None.


ESR: [Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: 
This is printing bug and printing is a important function in an Enterprise environment.

User impact if declined: 
Some of the combinations of print settings will not be saved.

Fix Landed on Version: 63

Risk to taking this patch (and alternatives if risky): Extremely low

String or UUID changes made by this patch: N/A

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #9003002 - Flags: approval-mozilla-esr60?
Attachment #9003002 - Flags: approval-mozilla-beta?
Flags: needinfo?(mantaroh) → qe-verify+
Comment on attachment 9003002 [details]
Bug 1479071 - Revert kPMDataFormatXMLCompressed to kPMDataFormatXMLNormal. r=mstange

Simple fix for a printing regression likely to affect enterprise users. Approved for 62.0b20 and ESR 60.2.
Attachment #9003002 - Flags: approval-mozilla-esr60?
Attachment #9003002 - Flags: approval-mozilla-esr60+
Attachment #9003002 - Flags: approval-mozilla-beta?
Attachment #9003002 - Flags: approval-mozilla-beta+
Hello all,

I have reproduced the issue mentioned in Description using an affected 07-27-2018 FF Nightly build.

This issue is verified fixed using Firefox 620b20 and Nightly 63.0.a1(2018-08-23) on macOS 10.13.6. 

As per described in comment 11, this needs to be verified on ESR 60.2, so I will return to put a final resolution for this ticket when that build will be available.
Thanks, Ryan, Vlad!
Hello all,

As per comment 13, I have returned to check the fix on ESR 60.1.1 build and it is indeed verified fixed.
This issue can be closed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.