147909 - Override portions of xul prefs from embed package

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: Mac, defect)

Description

[Mike Pinkerton (not reading bugmail)]

Some embedding apps probably want to be able to override certain parts of the
XUL prefs window, such as removing the help button or removing panels.

we can do this in one of two ways:
1) replace the platformPrefOverlay.xul with whatever changes are needed by the
embedding app before packaging embed.jar
2) make our own dynamic overlays installed into the chrome dir before we package
embed.jar

(1) is easy. (2) is more complicated. Depends on what we want to pursue. I'm
pretty sure we need (2) to remove individual items from individual pref panels.
It is unclear to me if our current embedding clients need that level of
granularity. 

I'm tempted to stick with (1) because i'm overloaded, but i can be convinced
that (2) is a better, more general solution. Ideas?

Comment 1

[Adam Lock]

How does Netscape contain different prefs in this dialog compared to Mozilla. Is
there scope to make this a more generic mechanism?

Comment 2

[Mike Pinkerton (not reading bugmail)]

there's a file called communicatorOverlay.xul which i assume the commercial tree
replaces with its own overlay info since it's empty in the moz tree (and has a
comment to this effect).

we're basically doing the same thing. we could re-use communicatorOverlay
instead of prefPlatformOverlay.xul. Six of one, really.

Comment 3

[Mike Pinkerton (not reading bugmail)]

oops, mine

Comment 4

[Mike Pinkerton (not reading bugmail)]

well, this one is going on the back burner for a while. the main embeddor that
wanted it is going native prefs.

Comment 5

[Benjamin Smedberg]

Mass change of bugs in the Embedding: Mac component in preparation for archiving it. I don't believe any of these are useful any more, as we don't have a mac embedding API. If they are relevant, they should be moved to an alternate component.