Closed Bug 1479097 Opened 4 years ago Closed 4 years ago
clean up sentry code in processor
53 bytes, text/x-github-pull-request
|Details | Review|
The processor has several implementations of "send this error to sentry". That's kind of silly. One way to fix this is to make a utility function and change uses of it to call that. Another way to do this is to implement a singleton service in the same way that we do logging and metrics. That seems a bit "over-engineery", but maybe it's a better idea. This bug covers cleaning up the sentry code.
The reason this came up is that sentry code is intertwined in signature generation, but it really shouldn't be. In order to unify the two signature generation forks, I need to fix this. Given that, making this a P2 to fix soon.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Priority: -- → P2
Commits pushed to master at https://github.com/mozilla-services/socorro https://github.com/mozilla-services/socorro/commit/4d60c041cbff492b1ed51c40c4c8097fe8191b79 fix bug 1479097: unify sentry captureException uses This unifies the two Sentry captureException uses into a single capture_error implementation which sends the error to sentry if possible or logs an error. This also fixes a lot of the code and tests that used that so they're all passing in an exc_info() and not just exceptions. I'm not sure how some of that code worked--I suspect it didn't. https://github.com/mozilla-services/socorro/commit/7546f8de81f42679bf9428ea5d004b2ffcb88150 fix bug 1479097: cleanup sentry usage in processor This moves all sentry usage out of the signature generation code and into the SignatureGeneratorRule processor rule. It also adds appropriate tests--there weren't any tests for the SignatureGeneratorRule before for some reason. https://github.com/mozilla-services/socorro/commit/714ee961ee487baef962ca1c02758ca8d14273df Merge pull request #4528 from willkg/1479097-sentry-cleanup fix bug 1479097: sentry cleanup in processor
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.