Closed Bug 1479193 Opened 3 years ago Closed 3 years ago

Provide dummy built_in_addons.json in SeaMonkey

Categories

(SeaMonkey :: General, enhancement)

SeaMonkey 2.57 Branch
enhancement
Not set
minor

Tracking

(seamonkey2.57esr fixed, seamonkey2.60 fixed)

RESOLVED FIXED
seamonkey2.60
Tracking Status
seamonkey2.57esr --- fixed
seamonkey2.60 --- fixed

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file)

Firefox uses a json file for system add-ons. If the file is not bundled a log entry is generated. 

1510413615502   addons.xpi      WARN    List of valid built-in add-ons could not be parsed.: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.readURI]"  nsresult: "0x80520012 (N
S_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: _readAddons :: line 6386"  data: no] Stack trace: _readAddons()@resource://gre/modules/addons/XPIProvider.jsm:6386 < getAddonLocations()@re
source://gre/modules/addons/XPIProvider.jsm:6047 < getInstallState()@resource://gre/modules/addons/XPIProvider.jsm:1582 < checkForChanges()@resource://gre/modules/addons/XPIProvider.jsm:3195 < startup()@resource://gre/modules/addons/XPIP
rovider.jsm:2176 < callProvider()@resource://gre/modules/AddonManager.jsm:263 < _startProvider()@resource://gre/modules/AddonManager.jsm:730 < startup()@resource://gre/modules/AddonManager.jsm:897 < startup()@resource://gre/modules/Addon
Manager.jsm:3082 < observe()@addonManager.js:65

In the tradition of providing great interoperability with other programs using Gecko this file is located in a fixed Firefox only browser.jar and referenced in toolkit.

Thunderbird got rid of the startup warning in bug 1416480. Basically we need to do this 1:1.
1:1 port for suite
Attachment #8995709 - Flags: review?(iann_bugzilla)
Attachment #8995709 - Flags: approval-comm-esr60?
Severity: major → minor
Comment on attachment 8995709 [details] [diff] [review]
1479193-browseraddons.patch

LGTM r/a=me
Attachment #8995709 - Flags: review?(iann_bugzilla)
Attachment #8995709 - Flags: review+
Attachment #8995709 - Flags: approval-comm-esr60?
Attachment #8995709 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/1f654c15c4de
Provide dummy built_in_addons.json in SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.