Closed Bug 1479194 Opened 6 years ago Closed 6 years ago

SeaMonkey make package error in en-US libs-% step

Categories

(SeaMonkey :: Build Config, defect)

SeaMonkey 2.57 Branch
defect
Not set
blocker

Tracking

(seamonkey2.57esr affected)

RESOLVED INVALID
Tracking Status
seamonkey2.57esr --- affected

People

(Reporter: frg, Assigned: frg)

References

Details

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #1451847 +++

After aligning the make files for building Lightning with Thunderbird on Windows I still have a problem with mach package. The en-US build fails. 

The strange thing is it seems to be caused mainly by only 2 files:

locale/@AB_CD@/calendar/dialogs/calendar-event-dialog-reminder.dtd (%chrome/calendar/dialogs/calendar-event-dialog-reminder.dtd)
locale/@AB_CD@/calendar/calendar-event-dialog-attendees.properties (%chrome/calendar/calendar-event-dialog-attendees.properties)

Usually the calendar-event-dialog-reminder.dtd will be reported as missing  and it indeed is. Jarmaker seems to stop here in calendar/locales/jar.mn:

https://dxr.mozilla.org/comm-central/source/calendar/locales/jar.mn#34

All files up to this point are there. The file names contain a lot of dashes and I am not sure if I hit a bug in toolkit but beats me how Thunderbird can build sucessfully in automation. I am experiencing the same problem with a manual Thunderbird build. Might also be a path length problem on Windows but didn't try Linux yet.
Fixes the en_US build. Taking the step out seems to have no effect for en_US. zip and installer are ok.

Also removing an unused variable.
Attachment #8995710 - Flags: review?(iann_bugzilla)
Attachment #8995710 - Flags: approval-comm-esr60?
(In reply to Frank-Rainer Grahl (:frg) from comment #0)

> Usually the calendar-event-dialog-reminder.dtd will be reported as missing 
> and it indeed is. Jarmaker seems to stop here in calendar/locales/jar.mn:

In what way is it missing? https://dxr.mozilla.org/comm-central/source/calendar/locales/en-US/chrome/calendar/dialogs/calendar-event-dialog-reminder.dtd

Using current comm-esr60, building on linux with calendar works using mach without an issue.
> In what way is it missing?

It is not in the locales-en_US dir. Let me do a new build so that I can post the actual error. I just switched to mozbuild 3.2 and lets see if it occurs there too.
The actual error:
 1:39.63 mkdir -p '../../../dist/xpi-stage/locale-en-US/distribution/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/'
 1:39.73 d:/seabuild/release/comm-esr60-17/obj-x86_64-pc-mingw32/_virtualenv/Scripts/python.exe -m mozbuild.action.jar_maker   -d ..
/../../dist/xpi-stage/locale-en-US/distribution/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103} -t d:/seamonkey/comm-esr60/comm -f
 flat  -e --relativesrcdir=calendar/locales -c d:/seamonkey/comm-esr60/comm/calendar/locales/en-US --root-manifest-entry-appid='{926
50c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}' -DNDEBUG=1 -DTRIMMED=1 -DA11Y_LOG=1 -DACCESSIBILITY=1 -DBUILD_CTYPES=1 -DCROSS_COMPILE='' -DENAB
LE_INTL_API=1 -DENABLE_SYSTEM_EXTENSION_DIRS=1 -DEXPOSE_INTL_API=1 -DFIREFOX_VERSION=60.1.1 -DFORCE_PR_LOG=1 -DHAVE_64BIT_BUILD=1 -D
HAVE_FORCEINLINE=1 -DHAVE_INTTYPES_H=1 -DHAVE_IO_H=1 -DHAVE_ISATTY=1 -DHAVE_LOCALECONV=1 -DHAVE_MALLOC_H=1 -DHAVE_SEH_EXCEPTIONS=1 -
DHAVE_STDINT_H=1 -DHAVE_UINT64_T=1 -DJS_64BIT=1 -DJS_CODEGEN_X64=1 -DJS_DEFAULT_JITREPORT_GRANULARITY=3 -DJS_PUNBOX64=1 -DMALLOC_H='
<malloc.h>' -DMALLOC_USABLE_SIZE_CONST_PTR=const -DMOZILLA_OFFICIAL=1 -DMOZILLA_UAVERSION='"60.0"' -DMOZILLA_VERSION='"60.1.1"' -DMO
ZILLA_VERSION_U=60.1.1 -DMOZ_ALLOW_LEGACY_EXTENSIONS=1 -DMOZ_APP_UA_NAME='""' -DMOZ_APP_UA_VERSION='"2.57"' -DMOZ_BUILD_APP=comm/sui
te -DMOZ_BUNDLED_FONTS=1 -DMOZ_CONTENT_SANDBOX=1 -DMOZ_CRASHREPORTER=1 -DMOZ_DATA_REPORTING=1 -DMOZ_DISTRIBUTION_ID='"org.mozilla"'
-DMOZ_DLL_SUFFIX='".dll"' -DMOZ_ENABLE_SKIA=1 -DMOZ_FEEDS=1 -DMOZ_FFVPX=1 -DMOZ_FMP4=1 -DMOZ_GECKO_PROFILER=1 -DMOZ_GMP_SANDBOX=1 -D
MOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_LDAP_XPCOM=1 -DMOZ_LIBAV_FFT=1 -DMOZ_LOGGING=1 -DMOZ_MACBUNDLE_ID=org.mozilla.seamonkey -DMOZ_MAPI
_SUPPORT=1 -DMOZ_MEMORY=1 -DMOZ_MSVC_STL_WRAP_RAISE=1 -DMOZ_OLD_STYLE=1 -DMOZ_PEERCONNECTION=1 -DMOZ_PLACES=1 -DMOZ_RAW=1 -DMOZ_SAMP
LE_TYPE_FLOAT32=1 -DMOZ_SANDBOX=1 -DMOZ_SCTP=1 -DMOZ_SEPARATE_MANIFEST_FOR_THEME_OVERRIDES=1 -DMOZ_SRTP=1 -DMOZ_STATIC_JS=1 -DMOZ_ST
YLO=1 -DMOZ_STYLO_ENABLE=1 -DMOZ_SUITE=1 -DMOZ_TREE_CAIRO=1 -DMOZ_TREE_PIXMAN=1 -DMOZ_UPDATER=1 -DMOZ_UPDATE_CHANNEL=esr60 -DMOZ_USE
R_DIR='"Mozilla"' -DMOZ_VORBIS=1 -DMOZ_VPX_NO_MEM_REPORTING=1 -DMOZ_WEBM_ENCODER=1 -DMOZ_WEBRTC=1 -DMOZ_WEBRTC_ASSERT_ALWAYS=1 -DMOZ
_WEBRTC_SIGNALING=1 -DMOZ_WEBSPEECH=1 -DMOZ_WEBSPEECH_TEST_BACKEND=1 -DMOZ_WMF=1 -DMOZ_XUL=1 -DMSVC_HAS_DIA_SDK=1 -DNOMINMAX=1 -DNO_
NSPR_10_SUPPORT=1 -DNS_ENABLE_TSF=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DRELEASE_OR_BETA=1 -DSTATIC_JS_API=1 -DSTDC_HEADERS=1 -DTA
RGET_XPCOM_ABI='"x86_64-msvc"' -DUSE_SKIA=1 -DUSE_SKIA_GPU=1 -DU_STATIC_IMPLEMENTATION=1 -DU_USING_ICU_NAMESPACE=0 -DVPX_X86_ASM=1 -
DWIN32=1 -DWIN32_LEAN_AND_MEAN=1 -DWINVER=0x601 -DXP_WIN=1 -DXP_WIN32=1 -DX_DISPLAY_MISSING=1 -D_AMD64_=1 -D_CRT_NONSTDC_NO_WARNINGS
=1 -D_CRT_SECURE_NO_WARNINGS=1 -D_USE_MATH_DEFINES=1 -D_WIN32_IE=0x0800 -D_WIN32_WINNT=0x601 -D_WINDOWS=1 -DXPI_NAME=locale-en-US -D
AB_CD=en-US d:/seamonkey/comm-esr60/comm/calendar/locales/jar.mn
 1:39.99 processing d:/seamonkey/comm-esr60/comm/calendar/locales/jar.mn
 1:40.04 Traceback (most recent call last):
 1:40.04   File "c:\mozilla-build\python\Lib\runpy.py", line 174, in _run_module_as_main
 1:40.04     "__main__", fname, loader, pkg_name)
 1:40.04   File "c:\mozilla-build\python\Lib\runpy.py", line 72, in _run_code
 1:40.04     exec code in run_globals
 1:40.04   File "d:\seamonkey\comm-esr60\python\mozbuild\mozbuild\action\jar_maker.py", line 17, in <module>
 1:40.04     sys.exit(main(sys.argv[1:]))
 1:40.04   File "d:\seamonkey\comm-esr60\python\mozbuild\mozbuild\action\jar_maker.py", line 13, in main
 1:40.04     return mozbuild.jar.main(args)
 1:40.04   File "d:\seamonkey\comm-esr60\python\mozbuild\mozbuild\jar.py", line 608, in main
 1:40.04     jm.makeJar(infile, options.d)
 1:40.04   File "d:\seamonkey\comm-esr60\python\mozbuild\mozbuild\jar.py", line 333, in makeJar
 1:40.04     self.processJarSection(info, jardir)
 1:40.04   File "d:\seamonkey\comm-esr60\python\mozbuild\mozbuild\jar.py", line 388, in processJarSection
 1:40.04     self._processEntryLine(e, outHelper, jf)
 1:40.04   File "d:\seamonkey\comm-esr60\python\mozbuild\mozbuild\jar.py", line 485, in _processEntryLine
 1:40.04     outf = outHelper.getOutput(out)
 1:40.04   File "d:\seamonkey\comm-esr60\python\mozbuild\mozbuild\jar.py", line 531, in getOutput
 1:40.04     return open(out, 'wb')
 1:40.06 IOError: [Errno 2] No such file or directory: '../../../dist/xpi-stage/locale-en-US/distribution/extensions/{e2fda1a4-762b-
4020-b5ad-a41df1933103}\\chrome/calendar-en-US\\locale/en-US/calendar/dialogs/calendar-event-dialog-reminder.dtd'
 1:40.06 mozmake.EXE[6]: *** [d:/seamonkey/comm-esr60/config/rules.mk:1258: libs] Error 1
 1:40.06 mozmake.EXE[6]: Leaving directory 'd:/seabuild/release/comm-esr60-17/obj-x86_64-pc-mingw32/comm/calendar/locales'
 1:40.06 mozmake.EXE[5]: *** [d:/seamonkey/comm-esr60/config/rules.mk:434: default] Error 2
 1:40.06 mozmake.EXE[5]: Leaving directory 'd:/seabuild/release/comm-esr60-17/obj-x86_64-pc-mingw32/comm/calendar/locales'
Attached file mach package Error Log
Oupout doesn't look so goo in bugzilla so a txt file with it
Attached image Capture.PNG
Everything is there up to a point. If it works on Linux I suspect a path length error which is somehow swallowed. Will retry with a "shorter" object dir.
Well switching to a shorter object dir solves it so probably really a path length error.

https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file

Tom is this something which should be looked into in toolkit? jarmaker gives no error but seems to silently fail and not copy a file. With the switch to mozilla as topsource the path got also longer.
Flags: needinfo?(mozilla)
Comment on attachment 8995710 [details] [diff] [review]
1479194-buildfix.patch

That only leaves the obsolete variable. I will open a separate bug.
Attachment #8995710 - Flags: review?(iann_bugzilla)
Attachment #8995710 - Flags: approval-comm-esr60?
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Flags: needinfo?(mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: