Exclude graphics shared memory contents from snapshots

RESOLVED FIXED in Firefox 63

Status

()

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

Trunk
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

10 months ago
Posted patch patchSplinter Review
The graphics shared memory block (shared between the middleman process and all child processes) is used to transmit graphics data to the middleman when a child process is painting.  Currently, this memory is included in memory snapshots, so when one child is restoring a checkpoint it can race with other processes that are trying to transmit different graphics data.  This has been causing some graphics artifacts when rewinding.  There is no reason to include this memory in snapshots, since it is only used in the above case, so this patch excludes this memory from snapshots.
Attachment #8995715 - Flags: review?(nfroyd)
Attachment #8995715 - Flags: review?(nfroyd) → review+

Comment 1

10 months ago
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea2290c53efc
Exclude graphics shared memory contents from snapshots, r=froydnj.

Comment 2

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ea2290c53efc
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.