Closed Bug 1479200 Opened 7 years ago Closed 7 years ago

Exclude graphics shared memory contents from snapshots

Categories

(Core Graveyard :: Web Replay, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The graphics shared memory block (shared between the middleman process and all child processes) is used to transmit graphics data to the middleman when a child process is painting. Currently, this memory is included in memory snapshots, so when one child is restoring a checkpoint it can race with other processes that are trying to transmit different graphics data. This has been causing some graphics artifacts when rewinding. There is no reason to include this memory in snapshots, since it is only used in the above case, so this patch excludes this memory from snapshots.
Attachment #8995715 - Flags: review?(nfroyd)
Attachment #8995715 - Flags: review?(nfroyd) → review+
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ea2290c53efc Exclude graphics shared memory contents from snapshots, r=froydnj.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: