Closed Bug 1479204 Opened 6 years ago Closed 6 years ago

Build bustage at /build/src/js/src/wasm/WasmBaselineCompile.cpp when Gecko 63 merges to Beta on 2018-08-27

Categories

(Core :: JavaScript: WebAssembly, defect)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 + verified

People

(Reporter: RaulG, Assigned: lth)

References

Details

[Tracking Requested - why for this release]:

This might relate to Bug 1478616 where changes on emitPostBarrier are made

Central as Beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f96380a82b403baa1e4c2b3d0f88685b4bc5f83c&selectedJob=190712190

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=190712190&repo=try&lineNumber=12387

Log snippet: 

[task 2018-07-28T15:36:51.977Z] 15:36:51     INFO -  netwerk/socket
[task 2018-07-28T15:36:51.977Z] 15:36:51     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/socket'
[task 2018-07-28T15:36:51.980Z] 15:36:51     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/socket'
[task 2018-07-28T15:36:51.980Z] 15:36:51     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/socket'
[task 2018-07-28T15:36:52.068Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/base'
[task 2018-07-28T15:36:52.068Z] 15:36:52     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -m32 -march=pentium-m -o NetworkInfoServiceLinux.i_o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/obj-firefox/netwerk/base -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/docshell/base -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/netwerk/protocol/http -I/builds/worker/workspace/build/src/netwerk/socket -I/builds/worker/workspace/build/src/security/pkix/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O3 -fomit-frame-pointer -Werror -Wno-error=shadow -fprofile-generate  -MD -MP -MF .deps/NetworkInfoServiceLinux.i_o.pp   /builds/worker/workspace/build/src/netwerk/base/NetworkInfoServiceLinux.cpp
[task 2018-07-28T15:36:52.070Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/base'
[task 2018-07-28T15:36:52.070Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/base'
[task 2018-07-28T15:36:52.070Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/base'
[task 2018-07-28T15:36:52.071Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/base'
[task 2018-07-28T15:36:52.071Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/base'
[task 2018-07-28T15:36:52.071Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/lwbrk/gtest'
[task 2018-07-28T15:36:52.073Z] 15:36:52     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -m32 -march=pentium-m -o Unified_cpp_intl_lwbrk_gtest0.i_o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/intl/lwbrk/gtest -I/builds/worker/workspace/build/src/obj-firefox/intl/lwbrk/gtest -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O3 -fomit-frame-pointer -Werror -fprofile-generate  -MD -MP -MF .deps/Unified_cpp_intl_lwbrk_gtest0.i_o.pp   /builds/worker/workspace/build/src/obj-firefox/intl/lwbrk/gtest/Unified_cpp_intl_lwbrk_gtest0.cpp
[task 2018-07-28T15:36:52.073Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/lwbrk/gtest'
[task 2018-07-28T15:36:52.093Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/intl/uconv'
[task 2018-07-28T15:36:52.093Z] 15:36:52     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -m32 -march=pentium-m -o Unified_cpp_intl_uconv0.i_o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/intl/uconv -I/builds/worker/workspace/build/src/obj-firefox/intl/uconv -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O3 -fomit-frame-pointer -Werror -Wno-error=shadow -fprofile-generate  -MD -MP -MF .deps/Unified_cpp_intl_uconv0.i_o.pp   /builds/worker/workspace/build/src/obj-firefox/intl/uconv/Unified_cpp_intl_uconv0.cpp
[task 2018-07-28T15:36:52.093Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/intl/uconv'
[task 2018-07-28T15:36:52.094Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/mime'
[task 2018-07-28T15:36:52.094Z] 15:36:52     INFO -  mkdir -p '.deps/'
[task 2018-07-28T15:36:52.094Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/mime'
[task 2018-07-28T15:36:52.094Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/mime'
[task 2018-07-28T15:36:52.094Z] 15:36:52     INFO -  netwerk/mime
[task 2018-07-28T15:36:52.095Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/mime'
[task 2018-07-28T15:36:52.095Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/mime'
[task 2018-07-28T15:36:52.095Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/mime'
[task 2018-07-28T15:36:52.095Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/streamconv'
[task 2018-07-28T15:36:52.095Z] 15:36:52     INFO -  mkdir -p '.deps/'
[task 2018-07-28T15:36:52.095Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/streamconv'
[task 2018-07-28T15:36:52.095Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/streamconv'
[task 2018-07-28T15:36:52.095Z] 15:36:52     INFO -  netwerk/streamconv
[task 2018-07-28T15:36:52.095Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/streamconv'
[task 2018-07-28T15:36:52.095Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/streamconv'
[task 2018-07-28T15:36:52.095Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/streamconv'
[task 2018-07-28T15:36:52.102Z] 15:36:52     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2018-07-28T15:36:52.103Z] 15:36:52     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -m32 -march=pentium-m -o Unified_cpp_js_src41.i_o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DENABLE_SHARED_ARRAY_BUFFER -DEXPORT_JS_API -DJS_HAS_CTYPES '-DDLL_PREFIX="lib"' '-DDLL_SUFFIX=".so"' -DFFI_BUILDING -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-firefox/js/src -I/builds/worker/workspace/build/src/obj-firefox/js/src/ctypes/libffi/include -I/builds/worker/workspace/build/src/js/src/ctypes/libffi/src/x86 -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/js/src/js-confdefs.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O3 -fomit-frame-pointer -Werror -Wno-shadow -Werror=format -fno-strict-aliasing -fprofile-generate  -MD -MP -MF .deps/Unified_cpp_js_src41.i_o.pp   /builds/worker/workspace/build/src/obj-firefox/js/src/Unified_cpp_js_src41.cpp
[task 2018-07-28T15:36:52.103Z] 15:36:52     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/js/src/Unified_cpp_js_src41.cpp:47:0:
[task 2018-07-28T15:36:52.104Z] 15:36:52     INFO -  /builds/worker/workspace/build/src/js/src/wasm/WasmBaselineCompile.cpp: In member function 'void js::wasm::BaseCompiler::emitBarrieredStore(const mozilla::Maybe<js::wasm::RegPtr>&, js::wasm::RegPtr, js::wasm::RegPtr)':
[task 2018-07-28T15:36:52.104Z] 15:36:52     INFO -  /builds/worker/workspace/build/src/js/src/wasm/WasmBaselineCompile.cpp:5702:33: error: 'emitPreBarrier' was not declared in this scope
[task 2018-07-28T15:36:52.104Z] 15:36:52     INFO -           emitPreBarrier(valueAddr); // Preserves valueAddr
[task 2018-07-28T15:36:52.104Z] 15:36:52     INFO -                                   ^
[task 2018-07-28T15:36:52.104Z] 15:36:52     INFO -  /builds/worker/workspace/build/src/js/src/wasm/WasmBaselineCompile.cpp:5705:63: error: 'emitPostBarrier' was not declared in this scope
[task 2018-07-28T15:36:52.104Z] 15:36:52     INFO -           emitPostBarrier(object, otherScratch, valueAddr, value); // Consumes valueAddr
[task 2018-07-28T15:36:52.104Z] 15:36:52     INFO -                                                                 ^
[task 2018-07-28T15:36:52.104Z] 15:36:52     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1052: recipe for target 'Unified_cpp_js_src41.i_o' failed
[task 2018-07-28T15:36:52.105Z] 15:36:52     INFO -  make[5]: *** [Unified_cpp_js_src41.i_o] Error 1
[task 2018-07-28T15:36:52.105Z] 15:36:52     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2018-07-28T15:36:52.105Z] 15:36:52     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'js/src/target' failed
[task 2018-07-28T15:36:52.105Z] 15:36:52     INFO -  make[4]: *** [js/src/target] Error 2
[task 2018-07-28T15:36:52.105Z] 15:36:52     INFO -  make[4]: *** Waiting for unfinished jobs....
Assignee: nobody → lhansen
Yeah, not shocking.  This is just a missing ifdef somewhere, no reason for panic.
(In reply to Lars T Hansen [:lth] from comment #2)
> Yeah, not shocking.  This is just a missing ifdef somewhere, no reason for
> panic.

This is still breaking beta sims without that backout. Can you fix it?
Flags: needinfo?(lhansen)
Yes, I will fix it today :)
Flags: needinfo?(lhansen)
(In reply to Lars T Hansen [:lth] from comment #4)
> Yes, I will fix it today :)

That's great to hear. Thank you for looking into this. 
Regards
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f587d77a7782
Fix the placement of an #endif. r=me  DONTBUILD
https://hg.mozilla.org/mozilla-central/rev/f587d77a7782
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.