1479219 - Port | Bug 692295 nsWindowsShellService's ShortcutMaintenance can be removed ~ 6/12| to TB

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Ian Neal]

Following Bug 577867 - No way to un-group separate instances on Windows 7 TaskBar which landed for TB, there was a followup Bug 692295 - nsWindowsShellService's ShortcutMaintenance can be removed ~ 6/12 which was never ported.

Comment 1

[Ian Neal]

Attachment: Simple port of bug 692295

As far as I could see there are no jumplists for TB
Treeherder try build:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=4fed9b61dc46acf76c63aeb6d2a538d87fb0634d

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8995756 [details] [diff] [review]
Simple port of bug 692295

Thanks. Interesting to see that we had the code copied to C-C.

Comment 3

[Jorg K (CEST = GMT+2)]

(In reply to Ian Neal from comment #1)
> As far as I could see there are no jumplists for TB
Please educate the reviewer. Last I heard of jumplists was in bug 1373565 (https://hg.mozilla.org/comm-central/rev/412abacb5ca5cdb65f08adfcae5846b275377d6b) and that code is still there in mail/components/wintaskbar/windowsJumpLists.js and elsewhere. But that's unrelated to the patch here, isn't it?

Comment 4

[Ian Neal]

(In reply to Jorg K (GMT+2) from comment #3)
> (In reply to Ian Neal from comment #1)
> > As far as I could see there are no jumplists for TB
> Please educate the reviewer. Last I heard of jumplists was in bug 1373565
> (https://hg.mozilla.org/comm-central/rev/
> 412abacb5ca5cdb65f08adfcae5846b275377d6b) and that code is still there in
> mail/components/wintaskbar/windowsJumpLists.js and elsewhere. But that's
> unrelated to the patch here, isn't it?

Sorry, I should have been more precise in my comment. Amended comment is:
As far as I could see there are no changes required for jumplists in TB.
Compare with:
https://hg.mozilla.org/mozilla-central/diff/1c26e57c1899/browser/modules/WindowsJumpLists.jsm

Comment 5

[Ian Neal]

Comment on attachment 8995756 [details] [diff] [review]
Simple port of bug 692295

[Approval Request Comment]
Regression caused by (bug #): 692295
User impact if declined: None
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): None, removing unused code

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8995756 [details] [diff] [review]
Simple port of bug 692295

OK. I'll land this now, right?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/83e8ac3fce3d
Port bug 692295: remove nsWindowsShellService::ShortcutMaintenance. r=jorgk DONTBUILD

Comment 8

[Jorg K (CEST = GMT+2)]

Landed with DONTBUILD. The Daily run in less than an hour will take care of building. This way I get a nice clean treeherder and not the Daily run glued to the previous push ... just in case you were wondering. In buildbot times this wouldn't have worked since back then, the Dailies ran on the last non-DONTBUILD push. So things are constantly getting better ;-)

Comment 9

[Jorg K (CEST = GMT+2)]

TB 60 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/6655f24b1e4d