1479270 - No "error" event when audio element load() hits a 404

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[rudolfenberg]

Attachment: audio-error-test.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

Steps to reproduce:

I'm attempting to play audio from a variable URL that may or may not return a 404 status code. I need to use an event listener to detect these failures. You can look at the simple test case I attached. 


Actual results:

No error event is fired.


Expected results:

An error event should be fired when the request hits a 404. This is the case with Google Chrome on the desktop and android, as well as Firefox on the desktop.

Comment 1

[Sorina Florean [:sflorean]]

Thanks for the report!

Tested with Nokia 6(Android 7.1.1) and Xiaomi Mi4i (Android 5.0.2) and the issue is reproducible on all branches. Tested on Chrome as well. Marking the bug as NEW.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Regressed in Firefox 55.0a1
 8:21.84 INFO: Got as far as we can go bisecting nightlies...
 8:21.84 INFO: Last good revision: 272ce6c2572164f5f6a9fba2a980ba9ccf50770c (2017-03-29)
 8:21.84 INFO: First bad revision: 60d7a0496a3673450ddbc37ec387525148c32604 (2017-03-30)
 8:21.84 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=272ce6c2572164f5f6a9fba2a980ba9ccf50770c&tochange=60d7a0496a3673450ddbc37ec387525148c32604

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

changeset:   350214:f9066223064f
user:        Alastor Wu <[e-mail]>
date:        Wed Mar 29 11:55:50 2017 +0800
summary:     Bug 1247433 - don't set error for unsupported type media. r=JamesCheng,jwwang,kaku

Alastor can you have a look at this testcase. Looks like bug 1247433 regressed it.

Comment 4

[Alastor Wu [:alwu]]

Will check it later, thank you.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1479270 - part1 : remove external player support in media element.

Since we have native HLS support in 59 [1], we don't need those code anymore.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1345752

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1479270 - part2 : remove HLS video player.

Since we have native HLS support in 59 [1], we can remove those codes which is used to play HLS.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1345752

Comment 8

[Jean-Yves Avenard [:jya]]

Comment on attachment 9003633 [details]
Bug 1479270 - part1 : remove external player support in media element.

Jean-Yves Avenard [:jya] has approved the revision.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 9003634 [details]
Bug 1479270 - part2 : remove HLS video player.

James Willcox (:snorp) ([e-mail]) has approved the revision.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/643ef11ea720
part1 : remove external player support in media element. r=jya

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1676f895a710
part2 : remove HLS video player. r=snorp

Comment 12

[Andreea Pavel [:apavel]]

Backed out for android lint failures

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1676f895a7102a9fab1a84c2a5e43449edd7f870

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=195778066&repo=autoland&lineNumber=3256

Backout: https://hg.mozilla.org/integration/autoland/rev/bbbab4206c4696bf21ae5e8b93f06bd38dd015b3

Comment 13

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8dc950325402e52725a24ede5e06cce604ea3377

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d14df5075725
part1 : remove external player support in media element. r=jya

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75b11f12bf4b
part2 : remove HLS video player. r=snorp

Comment 16

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d14df5075725
https://hg.mozilla.org/mozilla-central/rev/75b11f12bf4b

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Too late for 61/62. Fx63 will be on Beta with this fix included next week.

Comment 18

[Stefan Deiac]

Verified as fixed on latest Nightly 63.0a1 (2018-09-04) with Nokia 6 (Android 7.1.1) and OnePlus 5T (Android 8.1.0).