1479289 - Port |Bug 1420514 - Remove or hide the update features in the preferences|

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Mark Barnes]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180704003137

Steps to reproduce:

63.0a1 (2018-07-24) (64-bit) -- and earlier versions

In Tools->Options->Advanced->Update I have "Never check for updates" checked.

I just let the app run



Actual results:

(Almost) every morning, I get a dialog, telling there is an update.

When I dismiss this dialog, and go to Help->About, the "Check for Updates" button is there.


Expected results:

Daily should not be checking for updates automatically, and the "update is available" dialog should not be coming up.

Is this perhaps by design, because this is the development version???

WHY DO I HAVE "Never check for updates" CHECKED???   Because I have noticed that, when I allow this dialog to perform the update, Daily gets updated to the version that was current AT THE TIME THAT THE DIALOG WAS DISPLAYED, and not to the latest.  I might have been away from my system for a few days, and when I come back to it, the "update is available" dialog is there.  I always want the latest!

Comment 1

[Masatoshi Kimura [:emk]]

Since the platform (the common backend for Firefox and Thunderbird) removed the "app.update.enabled" pref, the Thunderbird UI should reflect the change (that is, remove the "Never check for updates" choice from the preference UI).

Comment 2

[Richard Marti (:Paenglab)]

I planned already to port it.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: No-noUpdate.patch

Does this look correct? We have no policy to change this to use it.

I've set app.update.interval to a very high value to not get the update check.

Comment 4

[:aceman]

Comment on attachment 8997836 [details] [diff] [review]
No-noUpdate.patch

Review of attachment 8997836 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not happy with this direction of m-c, but thanks for porting it.

::: mail/base/content/aboutDialog-appUpdater.js
@@ -131,5 @@
> -  // true when updating is disabled by an administrator.
> -  get updateDisabledAndLocked() {
> -    return !this.updateEnabled &&
> -           Services.prefs.prefIsLocked("app.update.enabled");
> -  },

Maybe we could keep the hunk m-c is adding here:
+  // true when updating has been disabled by enterprise policy
+  get updateDisabledByPolicy() {
+    return Services.policies && !Services.policies.isAllowed("appUpdate");
   },

(and use it in get backgroundUpdateEnabled()). It will return false as we have no policies yet, but our code will better resemble what m-c has.

::: mail/base/content/aboutDialog.xul
@@ -89,5 @@
>                  <label>&update.failed.start;</label><label id="failedLink" class="text-link">&update.failed.linkText;</label><label>&update.failed.end;</label>
>                </hbox>
> -              <hbox id="adminDisabled" align="center">
> -                <label>&update.adminDisabled;</label>
> -              </hbox>

m-c keeps this so could we even when currently unused.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: No-noUpdate.patch

Changed the adminDisabled hbox to policyDisabled and added the policy check which should always give false.

Comment 6

[:aceman]

Comment on attachment 8998121 [details] [diff] [review]
No-noUpdate.patch

Review of attachment 8998121 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 7

[Jorg K (CEST = GMT+2)]

So how do we do the "never check for updates now"? That is an important option in two cases: To avoid update to a defective version, like TB 52.9.0, or for Daily users not wishing to update every day.

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to Jorg K (GMT+2) from comment #7)
> So how do we do the "never check for updates now"? That is an important
> option in two cases: To avoid update to a defective version, like TB 52.9.0,
No one would ever get updated to 52.9.0 - all 52.* should be updating to 52.9.1

> or for Daily users not wishing to update every day.

You cannot do it in UI anymore.  I have followed Martin's lead, and set app.update.interval to 99999999 (I'm curious what he set it to)

Comment 9

[Richard Marti (:Paenglab)]

(In reply to Wayne Mery (:wsmwk) from comment #8)
> (In reply to Jorg K (GMT+2) from comment #7)
> > or for Daily users not wishing to update every day.

Actually no other option than the interval. To follow FX we'd need the policies.

> You cannot do it in UI anymore.  I have followed Martin's lead, and set
> app.update.interval to 99999999 (I'm curious what he set it to)

One digit less. But using now yours. :-)

Comment 10

[Jorg K (CEST = GMT+2)]

We should add something to the UI that will allow advanced users to set this, like: Update check interval: ___, use maximum [x].

@Wayne: 52.9.0 was live for a while and during that time that option was useful.

Comment 11

[Magnus Melin [:mkmelin]]

Not auto-updating has been handy for development usage, to manually keep a copy of old versions, and also to swap between different versions.

I wouldn't recommend it to any real end users though.

Comment 12

[Richard Marti (:Paenglab)]

Okay, then no UI for this.

Comment 13

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #12)
> Okay, then no UI for this.
I think we should, see bug 1481589.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a123c1664ff9
Port bug 1420514 to TB: Remove manual update option (never check for updates). r=aceman