1479310 - Don't load content-UITour.js until needed

Status: RESOLVED FIXED

(Firefox :: Tours, enhancement, P1)

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1479310: Don't load content-UITour.js until needed.

Review commit: https://reviewboard.mozilla.org/r/260170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260170/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8995830 [details]
Bug 1479310: Don't load content-UITour.js until needed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260170/diff/1-2/

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3583823171dea4207f9ea5665060bcb559f5e586
Bug 1479310: Don't load content-UITour.js until needed. r=Mossop

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3583823171de

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for causing a big performance regression on OS X and as request by igoldan. 

https://hg.mozilla.org/mozilla-central/rev/fe6020e5c9d901a40fa2e7ea2f1ab2a36bf6d856

Comment 6

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5212e051d0397bda00f7a4a681ef19e651b302a7
Bug 1479310: Don't load content-UITour.js until needed. r=Mossop

Comment 7

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 5212e051d039 (Bug 1479310) for bc failures on /browser/browser_onboarding_uitour.js.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/bbfb137848d91ef9ec71e3387ca98294304ee725

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=5212e051d0397bda00f7a4a681ef19e651b302a7&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&selectedJob=192583216

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=192583216&repo=mozilla-inbound&lineNumber=4321

Comment 8

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/332b27e88d1199d89c419c9ae0fc276dfa4afaad
Bug 1479310: Don't load content-UITour.js until needed. r=Mossop

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/332b27e88d11

Comment 10

[Sam Foster [:sfoster] (he/him)]

I dont fully understand why this is showing up on the triage list as it is already resolved, but as it has a landed patch on it, P1.