Don't keep recording/replaying ContentParents alive

RESOLVED FIXED in Firefox 63

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

Trunk
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
When running the web replay mochitests, the middleman (and, transitively, their child processes) are kept alive indefinitely per ContentParent::ShouldKeepProcessAlive.  I think this is done so the content parents can be reused for new tabs, but we never reuse recording/replaying content parents.  Avoiding keeping these parents alive, as this patch does, avoids test failures at shutdown that seem to result from these parents not shutting down quickly enough.
Attachment #8995852 - Flags: review?(mrbkap)
Attachment #8995852 - Flags: review?(mrbkap) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34fd64eae90b
Don't keep recording/replaying ContentParents alive, r=mrbkap.
https://hg.mozilla.org/mozilla-central/rev/34fd64eae90b
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.