Closed
Bug 1479334
Opened 6 years ago
Closed 6 years ago
Don't keep recording/replaying ContentParents alive
Categories
(Core Graveyard :: Web Replay, enhancement)
Core Graveyard
Web Replay
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
756 bytes,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
When running the web replay mochitests, the middleman (and, transitively, their child processes) are kept alive indefinitely per ContentParent::ShouldKeepProcessAlive. I think this is done so the content parents can be reused for new tabs, but we never reuse recording/replaying content parents. Avoiding keeping these parents alive, as this patch does, avoids test failures at shutdown that seem to result from these parents not shutting down quickly enough.
Attachment #8995852 -
Flags: review?(mrbkap)
|
||
Updated•6 years ago
|
Attachment #8995852 -
Flags: review?(mrbkap) → review+
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/34fd64eae90b Don't keep recording/replaying ContentParents alive, r=mrbkap.
|
||
Comment 2•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/34fd64eae90b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•