Use JSAutoRealm instead of JSAutoRealmAllowCCW

RESOLVED FIXED in Firefox 63

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(11 attachments)

21.31 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
15.89 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
19.45 KB, patch
bholley
: review+
Details | Diff | Splinter Review
8.36 KB, patch
baku
: review+
Details | Diff | Splinter Review
13.81 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
11.93 KB, patch
kmag
: review+
Details | Diff | Splinter Review
16.22 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
18.72 KB, patch
bholley
: review+
Details | Diff | Splinter Review
24.57 KB, patch
luke
: review+
Details | Diff | Splinter Review
14.87 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
5.11 KB, patch
bhackett
: review+
Details | Diff | Splinter Review
JSAutoRealmAllowCCW and JSAutoRealm are mostly equivalent, but the latter asserts the object is not a cross-compartment wrapper. JSAutoRealmAllowCCW is deprecated and will go away at some point.

Most places use JSAutoRealmAllowCCW on something that can't be a CCW, so in these cases we can use JSAutoRealm instead. This bug focuses on these easy ones; the rest will be addressed in follow-up bugs.
Attachment #8995883 - Flags: review?(amarchesini) → review+
Attachment #8995892 - Flags: review?(bhackett1024) → review+
Attachment #8995889 - Flags: review?(luke) → review+
Attachment #8995882 - Flags: review?(bobbyholley) → review+
Attachment #8995887 - Flags: review?(bobbyholley) → review+
Attachment #8995886 - Flags: review?(mrbkap) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3e06f6ef7c0
part 3 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/xbl and dom/xul. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b27fd1e7ff0
part 4 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/workers and dom/worklet. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f6816c00bbb
part 7 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/src. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/7655b654db1a
part 8 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/wrapper. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf63775518d6
part 9 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/src. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e35974cdc14
part 11 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in toolkit/recordreplay/ipc. r=bhackett
Keywords: leave-open
Attachment #8995885 - Flags: review?(kmaglione+bmo) → review+
Attachment #8995884 - Flags: review?(continuation) → review+
Comment on attachment 8995879 [details] [diff] [review]
Part 1 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/base

>@@ -5659,17 +5659,17 @@ nsGlobalWindowOuter::CallerInnerWindow()

This code is gone on trunk.  Sorry for the bitrot... :(

r=me
Attachment #8995879 - Flags: review?(bzbarsky) → review+
Comment on attachment 8995880 [details] [diff] [review]
Part 2 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/bindings

r=me
Attachment #8995880 - Flags: review?(bzbarsky) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d96f0a5c7caf
part 1 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/base. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/c630c862f511
part 2 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/bindings. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fa4b862e677
part 5 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in remaining dom/ directories. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/c459ea4efa8d
part 6 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/loader. r=kmag
Comment on attachment 8995890 [details] [diff] [review]
Part 10 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in other directories

Review of attachment 8995890 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. I missed this request.
Attachment #8995890 - Flags: review?(mrbkap) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5545b566fd7
part 10 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in other directories. r=mrbkap
(In reply to Blake Kaplan (:mrbkap) from comment #17)
> Sorry for the delay. I missed this request.

No worries, I wasn't blocked on it yet.

Thanks for all the reviews.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.