Closed
Bug 1479363
Opened 7 years ago
Closed 7 years ago
Use JSAutoRealm instead of JSAutoRealmAllowCCW
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(11 files)
21.31 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
15.89 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
19.45 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
8.36 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
13.81 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
11.93 KB,
patch
|
kmag
:
review+
|
Details | Diff | Splinter Review |
16.22 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
18.72 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
24.57 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
14.87 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
5.11 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
JSAutoRealmAllowCCW and JSAutoRealm are mostly equivalent, but the latter asserts the object is not a cross-compartment wrapper. JSAutoRealmAllowCCW is deprecated and will go away at some point.
Most places use JSAutoRealmAllowCCW on something that can't be a CCW, so in these cases we can use JSAutoRealm instead. This bug focuses on these easy ones; the rest will be addressed in follow-up bugs.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8995879 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8995880 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8995882 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8995883 -
Flags: review?(amarchesini)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8995884 -
Flags: review?(continuation)
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8995885 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8995886 -
Flags: review?(mrbkap)
Assignee | ||
Comment 8•7 years ago
|
||
Attachment #8995887 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 9•7 years ago
|
||
Attachment #8995889 -
Flags: review?(luke)
Updated•7 years ago
|
Attachment #8995883 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 10•7 years ago
|
||
Attachment #8995890 -
Flags: review?(mrbkap)
Assignee | ||
Comment 11•7 years ago
|
||
Attachment #8995892 -
Flags: review?(bhackett1024)
Updated•7 years ago
|
Attachment #8995892 -
Flags: review?(bhackett1024) → review+
![]() |
||
Updated•7 years ago
|
Attachment #8995889 -
Flags: review?(luke) → review+
Updated•7 years ago
|
Attachment #8995882 -
Flags: review?(bobbyholley) → review+
Updated•7 years ago
|
Attachment #8995887 -
Flags: review?(bobbyholley) → review+
Updated•7 years ago
|
Attachment #8995886 -
Flags: review?(mrbkap) → review+
Comment 12•7 years ago
|
||
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3e06f6ef7c0
part 3 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/xbl and dom/xul. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b27fd1e7ff0
part 4 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/workers and dom/worklet. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f6816c00bbb
part 7 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/src. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/7655b654db1a
part 8 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/wrapper. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf63775518d6
part 9 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/src. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e35974cdc14
part 11 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in toolkit/recordreplay/ipc. r=bhackett
Assignee | ||
Updated•7 years ago
|
Keywords: leave-open
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a3e06f6ef7c0
https://hg.mozilla.org/mozilla-central/rev/0b27fd1e7ff0
https://hg.mozilla.org/mozilla-central/rev/3f6816c00bbb
https://hg.mozilla.org/mozilla-central/rev/7655b654db1a
https://hg.mozilla.org/mozilla-central/rev/cf63775518d6
https://hg.mozilla.org/mozilla-central/rev/4e35974cdc14
Updated•7 years ago
|
Attachment #8995885 -
Flags: review?(kmaglione+bmo) → review+
Updated•7 years ago
|
Attachment #8995884 -
Flags: review?(continuation) → review+
![]() |
||
Comment 14•7 years ago
|
||
Comment on attachment 8995879 [details] [diff] [review]
Part 1 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/base
>@@ -5659,17 +5659,17 @@ nsGlobalWindowOuter::CallerInnerWindow()
This code is gone on trunk. Sorry for the bitrot... :(
r=me
Attachment #8995879 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 15•7 years ago
|
||
Comment on attachment 8995880 [details] [diff] [review]
Part 2 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/bindings
r=me
Attachment #8995880 -
Flags: review?(bzbarsky) → review+
Comment 16•7 years ago
|
||
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d96f0a5c7caf
part 1 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/base. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/c630c862f511
part 2 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/bindings. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fa4b862e677
part 5 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in remaining dom/ directories. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/c459ea4efa8d
part 6 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/loader. r=kmag
Comment 17•7 years ago
|
||
Comment on attachment 8995890 [details] [diff] [review]
Part 10 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in other directories
Review of attachment 8995890 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for the delay. I missed this request.
Attachment #8995890 -
Flags: review?(mrbkap) → review+
Comment 18•7 years ago
|
||
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5545b566fd7
part 10 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in other directories. r=mrbkap
Assignee | ||
Comment 19•7 years ago
|
||
(In reply to Blake Kaplan (:mrbkap) from comment #17)
> Sorry for the delay. I missed this request.
No worries, I wasn't blocked on it yet.
Thanks for all the reviews.
Keywords: leave-open
Comment 20•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d96f0a5c7caf
https://hg.mozilla.org/mozilla-central/rev/c630c862f511
https://hg.mozilla.org/mozilla-central/rev/1fa4b862e677
https://hg.mozilla.org/mozilla-central/rev/c459ea4efa8d
https://hg.mozilla.org/mozilla-central/rev/f5545b566fd7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•