Closed Bug 1479388 Opened 2 years ago Closed 2 years ago

Refactor gc/WeakMap.h to split out method definitions into a separate file

Categories

(Core :: JavaScript: GC, enhancement)

61 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

WeakMap.h ends up being included by most .cpp files yet it contains a ton of inline code that is only relevant to the GC.  This bug is to split out method definitions into a separate -inl.h file.
Patch to move most inline method definitions into a new -inl.h file.
Attachment #8995967 - Flags: review?(sphink)
Comment on attachment 8995967 [details] [diff] [review]
bug1479388-weakmap-includes

Review of attachment 8995967 [details] [diff] [review]:
-----------------------------------------------------------------

Vastly better, thanks.

I remember thinking "nothing much will need to include this header, so it should be fine to cram in whatever is needed", and later starting to notice that I had been wrong.
Attachment #8995967 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e988c40d5519
Move most WeakMap inline method definitions into a separate header r=sfink
Backed out changeset e988c40d5519 (Bug 1479388) for spidermonkey bustages in /builds/worker/workspace/build/src/js/src/vm/Debugger-inl on a CLOSED TREE

Failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=191065197
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191065197&repo=mozilla-inbound&lineNumber=6074

[task 2018-07-31T08:57:22.174Z] 08:57:22     INFO -  /builds/worker/workspace/build/src/js/src/vm/Debugger-inl.h:12:28: fatal error: gc/WeakMap-inl.h: No such file or directory
[task 2018-07-31T08:57:22.174Z] 08:57:22     INFO -   #include "gc/WeakMap-inl.h"
[task 2018-07-31T08:57:22.175Z] 08:57:22     INFO -                              ^
[task 2018-07-31T08:57:22.175Z] 08:57:22     INFO -  compilation terminated.
[task 2018-07-31T08:57:22.175Z] 08:57:22     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1086: recipe for target 'Interpreter.o' failed
[task 2018-07-31T08:57:22.175Z] 08:57:22     INFO -  make[4]: *** [Interpreter.o] Error 1
[task 2018-07-31T08:57:22.175Z] 08:57:22     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2018-07-31T08:57:22.175Z] 08:57:22     INFO -  make[4]: *** Waiting for unfinished jobs....
Flags: needinfo?(jcoppeard)
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43730ff0303f
Move most WeakMap inline method definitions into a separate header r=sfink
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/959675040740
Backed out changeset e988c40d5519 for spidermonkey bustages in /builds/worker/workspace/build/src/js/src/vm/Debugger-inl on a CLOSED TREE
Relanded in comment 5.
Flags: needinfo?(jcoppeard)
https://hg.mozilla.org/mozilla-central/rev/43730ff0303f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.