1479448 - Cutting event in calendar view using ctrl+x triggers cutting even if cmd_cut is not enabled

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[[:MakeMyDay]]

STR:
1. switch to calendar view and have at least one event in view
2. make the calendar the event is stored in read-only
3. select the event in the view
4. right click on the event to verify the context menu option |cut| is disabled
5. close the context menu
6. press ctrl+x to cut the event

Observed:
The cut operation is triggered.

Expected:
No operation will be triggerd at all, since the respective command cmd_cut is effectively disabled.

This is already an issue in ESR52 but gets more obvious in ESR60 if you try to cut a recurring event, since you now get prompted on whether you want to cut the occurrence or series.

A bandaid would be to check for whether aCommand is really enabled at [1], but we should find the root cause. Maybe other command are affected as well.

[1] https://searchfox.org/comm-central/source/calendar/base/content/calendar-common-sets.js#719

Comment 1

[[:MakeMyDay]]

Attachment: NoUnintendedCommandExecution-V1.diff

Interestingly, the mail code seems to suffer from the same issue in some circumstances since its bails out explicitely in doCommand of the FolderPaneController also referring to cmd_cut. [1]

So the attached patch follows that very approach.

[1] https://searchfox.org/comm-central/source/mail/base/content/mail3PaneWindowCommands.js#74

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dccaf0add9e3
Avoid unintended command excecution if command is not enabled. r=philipp

Comment 3

[Jorg K (CEST = GMT+2)]

TB 60 ESR, Cal 6.2:
https://hg.mozilla.org/releases/comm-esr60/rev/fba8ffb861bbff50fb2b8138ffe4f5fb9208b561