1479449 - Cutting a recurring event prompts the user twice to ask whether to operate on the occurrence or series

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[[:MakeMyDay]]

When cutting a recurring event e.g. in the calendar view, the user get expectedly prompted  to decide whether to cut the occurrence or the series. Once done, there is a second unwanted prompt asking whether to delete the occurence or the series.

This is unfortunate from UX perspective and a potential data loss risk if the user decides for the occurrence in the first and the series in the second prompt.

Comment 1

[[:MakeMyDay]]

Attachment: AvoidAdditionalPromptWhenCutting-V1.diff

This patch avoid the second occurrence prompt for the deletion operation when cutting. On top of that, it fixes two bugs in the paste code that make pasting impossible atm.

I have another patch in the queue that gets rid of the additional |send notification| dialog when cutting or deleting, but that includes string changes and will therefore not be available for 6.2 - I'll file a follow-up bug for that.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8997579 [details] [diff] [review]
AvoidAdditionalPromptWhenCutting-V1.diff

Review of attachment 8997579 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for figuring this out!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/59e9c188fedb
Avoid an additional prompt when deleting as part of cutting a recurring event. r=philipp

Comment 4

[Martin Schröder [:mschroeder]]

May you have fixed any of the open bugs from the list at https://mzl.la/2MhiAjY as you mentioned fixing two bugs in the paste code?

Comment 5

[[:MakeMyDay]]

The mentioned fixes have been regressions introduced with bug 463402.

Some of the bugs from your list can likely be considered fixed because the user cannot get into that sitauation anymore, at least accidentally. Starting with 6.2, there are some improvemments for cut/copy/paste: the user can explicitely select the target calendar from a list of available writable calendars to paste into (bug 719351), the user can explicitely decide whether to copy/cut the series or an occurrence if trying to cut/copy a recurring event occurrence (bug 393084), cutting will not be possible anymore if the command is disabled (bug 1479448). Candidates from your list - without reading the bug details - are at leasr 1203909, 1083795, 632374, 926055, maybe 1018584 (test driving welcome, if have some time ;-) - we can start poking reporters once we released, atm it doesn't make sense to point them to the last b10).

Known to be not fixed (yet): 1477387, 1257156, 607569, copying/cutting ocurrences still needs improvement due to our fake-master handling (but that's not about the pasting itself, but to deal with the items later on, e.g. the fake-master-item will not be deleted when deleting the only copied occurrence).

Comment 6

[Jorg K (CEST = GMT+2)]

TB 60 ESR, Cal 6.2:
https://hg.mozilla.org/releases/comm-esr60/rev/b015e76f95e34ec2432bde120706a5b22f681876