Closed Bug 1479454 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12229 - Create a dictionary of {item_type: ManifestItemClass}

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12229 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12229
Details from upstream follow.

James Graham <james@hoppipolla.co.uk> wrote:
>  Create a dictionary of {item_type: ManifestItemClass}
>  
>  Sometimes we need to know all the types of test that exist. Typically
>  this has either been done by hardcoding a list or using some custom
>  approach to finding all the subclasses of the original. Instead it
>  makes sense to have the classes register themselves on creation so
>  that we can simply look in the registry for the types.
>  
>  To do this we use a cusom metaclass that first constucts the class
>  object and then adds it to the registry.
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e54c63c48323
[wpt PR 12229] - Create a dictionary of {item_type: ManifestItemClass}, a=testonly
https://hg.mozilla.org/mozilla-central/rev/e54c63c48323
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.