1479463 - For RSS account type, Remove "Check for new articles at startup"

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Wayne Mery (:wsmwk)]

From Bug #1479434 "Check for new articles at startup is a legacy thing which I should have removed. About a minute after startup, all feeds are now checked to see if their update frequency has expired and pause state.  So check at startup is pretty useless."

Comment 1

[alta88]

Attachment: nofeedLoginAtStartup.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8996140 [details] [diff] [review]
nofeedLoginAtStartup.patch

Review of attachment 8996140 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks! r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d4d13b229f99
For RSS account type, remove 'Check for new articles at startup'. r=mkmelin

Comment 4

[alta88]

Comment on attachment 8996140 [details] [diff] [review]
nofeedLoginAtStartup.patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: crash in Subscribe dialog UI in certain cases.
Testing completed (on c-c, etc.):  manual.
Risk to taking this patch (and alternatives if risky): very low.

I think the tracking flag was the wrong thing to set as it's not being noticed. Anyway, the major thing here is getting rid of useless UI, but the more important thing is the lines in feed-subscriptions.js which fixes making the UI unusable sometimes.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8996140 [details] [diff] [review]
nofeedLoginAtStartup.patch

Indeed, I didn't notice the flag. I'll ship it in TB 60.2.1 RSN(TM) ;-)

Comment 6

[Jorg K (CEST = GMT+2)]

TB 60.2 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/d10016aa761f650b158d7a088e1d7518069ff968

I hope no one gets upset about the string *removals*.

Oh, the flag would have been tracking-thunderbird_esr60.

Comment 7

[alta88]

thanks.