Closed Bug 1479471 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12198 - Update buffered amount when async callbacks are called

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12198 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12198
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:
>  Update buffered amount when async callbacks are called
>  
>  If an asynchronous callback is called, it means we must have returned to
>  the start of the event loop. Ensure that any consumed bufferedAmount is
>  reflected in that case. Do not reflect bufferedAmount if the EventQueue
>  is paused, as that means that we may be in a nested event loop.
>  
>  Add a unit test for this case. Also add a unit test for normal
>  bufferedAmount behaviour, as there wasn't one.
>  
>  Add a web platform test for what happens if a sync XHR is performed
>  between calling send() and looking at bufferedAmount.
>  
>  BUG=856651
>  
>  Change-Id: Iafa2d619a1eb5284b64500ac03d336fb6380193b
>  Reviewed-on: https://chromium-review.googlesource.com/1151086
>  WPT-Export-Revision: 3c3e17817d5adbb16c1f7ce21814a7e7bf2d6b77
Ran 3 tests and 3 subtests
OK     : 3
PASS   : 2[linux32-debug], 3[linux32-opt,linux64-debug,linux64-opt]
FAIL   : 1[linux32-debug]

New tests that have failures or other problems:
/websockets/bufferedAmount-unchanged-by-sync-xhr.any.html
    bufferedAmount should not be updated during a sync XHR: FAIL[linux32-debug]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bb7cfcec74f
[wpt PR 12198] - Update buffered amount when async callbacks are called, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/94106f7660b1
[wpt PR 12198] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/4bb7cfcec74f
https://hg.mozilla.org/mozilla-central/rev/94106f7660b1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.