1479510 - Add a telemetry probe for the SDP comparer that records failed rust parsings.

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement)

Description

[Johannes Willbold]

There needs to be a telemetry probe that records if the rsdparsa fails to parse the SDP.

Comment 1

[Johannes Willbold]

Attachment: Bug 1479510: Added a telemetry probe that records failed rsdparsa parsings,

Added a telemetry probe that records failed rsdparsa parsings and whether the sipcc result contains errors.

Review commit: https://reviewboard.mozilla.org/r/260296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260296/

Comment 2

[Johannes Willbold]

Comment on attachment 8996025 [details]
Bug 1479510: Added a telemetry probe that records failed rsdparsa parsings,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260296/diff/1-2/

Comment 3

[Dan Minor [:dminor]]

Comment on attachment 8996025 [details]
Bug 1479510: Added a telemetry probe that records failed rsdparsa parsings,

https://reviewboard.mozilla.org/r/260296/#review267576

lgtm, it would be nice to know what the rsdparsa errors were if there were no sipcc errors, but I'm guessing that would not be possible from a privacy point of view.

Comment 4

[Johannes Willbold]

Comment on attachment 8996025 [details]
Bug 1479510: Added a telemetry probe that records failed rsdparsa parsings,

https://reviewboard.mozilla.org/r/260296/#review267576

Yes, this would basically defeat the approach of catgorizing the errors. We can still add more telemtry if this is a frequent errror.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc3cf7417929
Added a telemetry probe that records failed rsdparsa parsings, r=dminor

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/dc3cf7417929