1479518 - Require `products` key for new probes in Histograms.json

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Frank Bertsch [:frank]]

It's difficult to know what is usable in the mobile-metrics ping. It is worth it to require the `products` field for new pings, especially to ensure we know which ones are Firefox-specific (lots of TIME_TO_, FX_, etc. are).

Whether this bug includes making a first-pass at specifying products for existing probes is up to the implementer.

Comment 1

[Chris H-C :chutten]

I will form a proposal about how to tackle this so we can shop it around to stakeholders for input and education.

Comment 2

[Frank Bertsch [:frank]]

This may be helpful, [0] is a list of all metrics reported by GeckoView. We can get something similar for Fennec, but that has to be done in Spark.

[0] https://sql.telemetry.mozilla.org/queries/57750/source

Comment 3

[Chris H-C :chutten]

I've written up a proposal for what this'll take. Frank, what are your thoughts? Can you think of others who should give this a look-over before I pass it to fx-data-platform for general input? 

https://docs.google.com/document/d/1p1tBJaUnKOqGN_Yo7ySbfVdIu8c9_PCNJ1kh4zyXOyI/edit#

Comment 4

[Frank Bertsch [:frank]]

Reviewed. Taking it to fx-data-platform seems like a good next step.

Comment 5

[Georg Fritzsche [:gfritzsche]]

Chris, can you score this bug?

Comment 6

[Chris H-C :chutten]

Current status: seeking individual impact feedback from Firefox developers who will be the most affected by this change. :dao gave verbal acceptance of the idea in practice, but I'd like a couple of reviews of the document to point out some flaws.

Then off to estimation for timeboxing, then to firefox-dev for announcing. Implementation will be a subsequent bug.

Comment 7

[Chris H-C :chutten]

Individual Impact Feedback is done. When I asked on Slack#firefox :felipe, :johannh, and :mnoorenberghe offered to review the doc. Concerns they raised ranged from Devs resisting this new field as there's nothing in the doc explaining how they themselves benefit, to mutability of the products key after it has already been set.

I have captured these in the text of the proposal so they aren't lost. I think we're ready to proceed.

Comment 8

[Chris H-C :chutten]

With the filing of the project meta, work here's done.