147954 - remove auth.savePassword, server->password, sever->savePassword, etc from nsDirPrefs.cpp

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[(not reading, please use [e-mail] instead)]

remove auth.savePassword, server->password, sever->savePassword, etc from 
nsDirPrefs.cpp

there's a lot we could clean up from nsDirPrefs.cpp.  (dmose and others want to 
remove it / rewrite it / replace it with the ldap service, but let's take one 
step at a time.)

now that dmose is going to land his LDAP auth code, and rdayal's existing LDAP 
auth code for LDAP replication doesn't use it, we should remove some of the 
savePassword junk for nsDirPrefs.cpp

the server doesn't need to know about savePassword or password, and we don't 
need to reflect those into prefs.

passwords should be saved into wallet (like dmose is doing), and the ui for 
remember password is on the password dialog.  (and to forget, we go to wallet 
and delete the remembered password.)

over to dmose, who hates nsDirPrefs.cpp too.

Comment 1

[(not reading, please use [e-mail] instead)]

the reason for this bug is to make nsDirPrefs.cpp less confusing, by removing 
unused and misleading code.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

My stance on this has changed a bit; see bug 148900 for details.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Assigning bugs that I'm not actively working on back to nobody; use
SearchForThis as a search term if you want to delete all related bugmail at
once.

Comment 4

[Mark Banner (:standard8)]

I fixed this quite a while ago. Not sure which bug so WFM.