Closed Bug 1479544 Opened Last year Closed Last year

Can we remove nsIXULChromeRegistry::ReloadChrome?

Categories

(Core :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

It seems to be unused.....

If we can remove this, we can remove nsGlobalWindowOuter::GetLocation too.

Zibi, I _think_ this is meant to be a localization thing; do you know anything about it?
Flags: needinfo?(gandalf)
That predates me quite a bit - the last code change is from 2005.

I looked through the diff of it, and found:

```
 #ifdef RELOAD_CHROME_WORKS
 // XXX ReloadChrome() crashes right now
             if ( isContent || (isLocale && selected) )
                 reg->ReloadChrome();
 #endif
```

which makes me guess that there was a time when bsmedberg hoped to get chrome reloading, likely from locale reasons, as you said.

I currently see no use of that in any codebase, and I doubt it'd work. We also will not want or need it in the future, so I'm all for removing the dead code.

Pike - does it sound reasonable to you as well?
Flags: needinfo?(gandalf) → needinfo?(l10n)
SGTM. If we need this concept again, we'll likely put it somewhere else.
Flags: needinfo?(l10n)
This was the only consumer of GetLocation() on outer windows.
Comment on attachment 8997276 [details]
Bug 1479544.  Remove nsIXULChromeRegistry::ReloadChrome.  r=mossop

Dave Townsend [:mossop] has approved the revision.

https://phabricator.services.mozilla.com/D2699
Attachment #8997276 - Flags: review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85fd8d212397
Remove nsIXULChromeRegistry::ReloadChrome.  r=mossop
Backed out changeset 85fd8d212397 (Bug 1479544) for windows build bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=85fd8d212397597441ffa7ad13e0c910f8fb856c

Backout link: https://hg.mozilla.org/integration/autoland/rev/6fceaaf81c7ecbc4f3a69baf2cb24996bc0a6a1d

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191886424&repo=autoland&lineNumber=33188

6:12:55     INFO -  mozmake.EXE[5]: Entering directory 'z:/build/build/src/obj-firefox/startupcache'
16:12:55     INFO -  z:/build/build/src/sccache2/sccache.exe z:/build/build/src/clang/bin/clang-cl.exe -fms-compatibility-version=19.13.26128 -m32 -FoUnified_cpp_startupcache0.i_o -c -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/startupcache -Iz:/build/build/src/obj-firefox/startupcache -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -flto=thin -fuse-ld=lld -Qunused-arguments -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -flto=thin -fuse-ld=lld -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -Wno-pragma-pack -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -O2 -Oy-  -Xclang -finstrument-functions-after-inlining -Xclang -MP -Xclang -dependency-file -Xclang .deps/Unified_cpp_startupcache0.i_o.pp -Xclang -MT -Xclang Unified_cpp_startupcache0.i_o    z:/build/build/src/obj-firefox/startupcache/Unified_cpp_startupcache0.cpp
16:12:55     INFO -  mozmake.EXE[5]: Leaving directory 'z:/build/build/src/obj-firefox/startupcache'
16:12:55     INFO -  mozmake.EXE[5]: Entering directory 'z:/build/build/src/obj-firefox/media/libyuv/libyuv/libyuv_libyuv'
16:12:55     INFO -  mozmake.EXE[5]: Leaving directory 'z:/build/build/src/obj-firefox/media/libyuv/libyuv/libyuv_libyuv'
16:12:55     INFO -  mozmake.EXE[5]: Entering directory 'z:/build/build/src/obj-firefox/toolkit/xre'
16:12:55     INFO -  z:/build/build/src/sccache2/sccache.exe z:/build/build/src/clang/bin/clang-cl.exe -fms-compatibility-version=19.13.26128 -m32 -FoUnified_cpp_toolkit_xre0.i_o -c -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DPROXY_PRINTING=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC '-DMOZ_APP_NAME="firefox"' '-DMOZ_APP_BASENAME="Firefox"' '-DMOZ_APP_DISPLAYNAME="Firefox Nightly"' '-DMOZ_APP_VERSION="63.0a1"' '-DOS_TARGET="WINNT"' '-DMOZ_WIDGET_TOOLKIT="windows"' -DMOZ_UPDATER '-DTARGET_OS_ABI="WINNT_x86-msvc"' -DGRE_MILESTONE=63.0a1 -DAPP_VERSION=63.0a1 '-DAPP_ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}' -DMOZ_BUILD_APP_IS_BROWSER -DTOPOBJDIR=z:/build/build/src/obj-firefox -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/toolkit/xre -Iz:/build/build/src/obj-firefox/toolkit/xre -Iz:/build/build/src/other-licenses/nsis/Contrib/CityHash/cityhash -Iz:/build/build/src/toolkit/components/printingui -Iz:/build/build/src/toolkit/components/printingui -Iz:/build/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/build/build/src/ipc/chromium/src -Iz:/build/build/src/ipc/glue -Iz:/build/build/src/toolkit/components/find -Iz:/build/build/src/toolkit/components/printingui/ipc -Iz:/build/build/src/toolkit/components/windowwatcher -Iz:/build/build/src/toolkit/profile -Iz:/build/build/src/config -Iz:/build/build/src/dom/base -Iz:/build/build/src/dom/commandhandler -Iz:/build/build/src/dom/ipc -Iz:/build/build/src/dom/webbrowserpersist -Iz:/build/build/src/testing/gtest/mozilla -Iz:/build/build/src/toolkit/crashreporter -Iz:/build/build/src/xpcom/build -Iz:/build/build/src/security/sandbox/chromium -Iz:/build/build/src/security/sandbox/chromium-shim -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -flto=thin -fuse-ld=lld -Qunused-arguments -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -flto=thin -fuse-ld=lld -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -Wno-pragma-pack -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -O2 -Oy-  -Xclang -finstrument-functions-after-inlining -Xclang -MP -Xclang -dependency-file -Xclang .deps/Unified_cpp_toolkit_xre0.i_o.pp -Xclang -MT -Xclang Unified_cpp_toolkit_xre0.i_o    z:/build/build/src/obj-firefox/toolkit/xre/Unified_cpp_toolkit_xre0.cpp
16:12:55     INFO -  In file included from z:/build/build/src/obj-firefox/toolkit/xre/Unified_cpp_toolkit_xre0.cpp:83:
16:12:55     INFO -  z:/build/build/src/toolkit/xre/nsNativeAppSupportWin.cpp(972,75):  error: no member named 'GetLocation' in 'nsPIDOMWindowOuter'
16:12:55     INFO -                          RefPtr<dom::Location> location = internalContent->GetLocation();
16:12:55     INFO -                                                           ~~~~~~~~~~~~~~~  ^
16:12:55     INFO -  1 error generated.
16:12:55     INFO -  z:/build/build/src/config/rules.mk:1086: recipe for target 'Unified_cpp_toolkit_xre0.i_o' failed
16:12:55     INFO -  mozmake.EXE[5]: *** [Unified_cpp_toolkit_xre0.i_o] Error 1
16:12:55     INFO -  mozmake.EXE[5]: Leaving directory 'z:/build/build/src/obj-firefox/toolkit/xre'
16:12:55     INFO -  mozmake.EXE[5]: *** Waiting for unfinished jobs....
16:12:55     INFO -  mozmake.EXE[5]: Entering directory 'z:/build/build/src/obj-firefox/media/libyuv/libyuv/libyuv_libyuv'
16:12:55     INFO -  mozmake.EXE[5]: Leaving directory 'z:/build/build/src/obj-firefox/media/libyuv/libyuv/libyuv_libyuv'
16:12:55     INFO -  mozmake.EXE[5]: Entering directory 'z:/build/build/src/obj-firefox/gfx/thebes'
16:12:55     INFO -  mozmake.EXE[5]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/thebes'
16:12:55     INFO -  mozmake.EXE[5]: Entering directory 'z:/build/build/src/obj-firefox/security/nss/lib/ssl/ssl_ssl'
16:12:55     INFO -  z:/build/build/src/sccache2/sccache.exe z:/build/build/src/clang/bin/clang-cl.exe -Xclang -std=gnu99 -fms-compatibility-version=19.13.26128 -m32 -Fosslver.obj -c -DNDEBUG -DTRIMMED=1 -DNSS_ALLOW_SSLKEYLOGFILE=1 -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DNSS_X86_OR_X64 -DNSS_X86 -DIN_LIBSSL -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -D_WINDOWS -DWIN95 -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -DNSS_DISABLE_LIBPKIX -DWIN32 -Iz:/build/build/src/security/nss/lib/ssl -Iz:/build/build/src/obj-firefox/security/nss/lib/ssl/ssl_ssl -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/private/nss -Iz:/build/build/src/obj-firefox/dist/include/nss -Iz:/build/build/src/obj-firefox/dist/include -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -flto=thin -fuse-ld=lld -Qunused-arguments -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -flto=thin -fuse-ld=lld -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4244 -wd4267 -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-pragma-pack -we4553 -Z7 -O2 -Oy-  -Xclang -MP -Xclang -dependency-file -Xclang .deps/sslver.obj.pp -Xclang -MT -Xclang sslver.obj    z:/build/build/src/security/nss/lib/ssl/sslver.c
16:12:55     INFO -  mozmake.EXE[5]: Leaving directory 'z:/build/build/src/obj-firefox/security/nss/lib/ssl/ssl_ssl'
16:12:55     INFO -  mozmake.EXE[5]: Entering directory 'z:/build/build/src/obj-firefox/gfx/thebes'
Looks like there's a Windows-only GetLocation() call that therefore did not come up in codesearch.  :(
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c690914f782
Remove nsIXULChromeRegistry::ReloadChrome.  r=mossop
https://hg.mozilla.org/mozilla-central/rev/3c690914f782
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → bzbarsky
You need to log in before you can comment on or make changes to this bug.