Closed Bug 1479586 Opened 3 years ago Closed 3 years ago

Fix racy test in browser_async_remove_tab.js

Categories

(Firefox :: Session Restore, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: nika, Assigned: nika)

References

Details

Attachments

(1 file)

This looks like it might be a similar failure to bug 1282990, but I'm not sure because of how old that bug is.

The problem was that the old code waited for any history entry to be pushed, however that would unfortunately happen too early during the load of the about:robots page when in the in-process case, as we were not waiting for the full SessionRestore to complete. 

This change makes us wait for the full SessionRestore into the new tab to complete first.
Comment on attachment 8996093 [details]
Bug 1479586 - Fix racy test in browser_async_remove_tab.js, r=mikedeboer

Kris Maglione [:kmag] has approved the revision.

https://phabricator.services.mozilla.com/D2525
Attachment #8996093 - Flags: review+
Pushed by nika@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69e4230dc38a
Fix racy test in browser_async_remove_tab.js, r=kmag
https://hg.mozilla.org/mozilla-central/rev/69e4230dc38a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.