Closed Bug 1479643 Opened Last year Closed Last year

Remove assertion that binary path matches between recording and replaying

Categories

(Core :: Web Replay, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bhackett, Assigned: bhackett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This assertion is bogus: we're comparing the binary path of the content process currently executing with the binary path of the content process used while recording, which we don't normally expect to match.
Attachment #8996167 - Flags: review?(continuation)
Why won't they match? Aren't they the same executable?
(In reply to Andrew McCreight [:mccr8] (away Aug 6 - 10) from comment #1)
> Why won't they match? Aren't they the same executable?

Recordings should be portable between executables that are built from the same m-c revision (we don't have any checks for the revision, but will eventually).  If a recording is made on one machine and then replayed on another (or in my case, another local copy of the same tree) then we'll hit this assert.
Comment on attachment 8996167 [details] [diff] [review]
patch

Review of attachment 8996167 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.
Attachment #8996167 - Flags: review?(continuation) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/172b93b2f600
Remove assertion that binary path matches between recording and replaying, r=mccr8.
https://hg.mozilla.org/mozilla-central/rev/172b93b2f600
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.