1479643 - Remove assertion that binary path matches between recording and replaying

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, enhancement)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

This assertion is bogus: we're comparing the binary path of the content process currently executing with the binary path of the content process used while recording, which we don't normally expect to match.

Comment 1

[Andrew McCreight [:mccr8]]

Why won't they match? Aren't they the same executable?

Comment 2

[Brian Hackett [Laid off!]]

(In reply to Andrew McCreight [:mccr8] (away Aug 6 - 10) from comment #1)
> Why won't they match? Aren't they the same executable?

Recordings should be portable between executables that are built from the same m-c revision (we don't have any checks for the revision, but will eventually).  If a recording is made on one machine and then replayed on another (or in my case, another local copy of the same tree) then we'll hit this assert.

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8996167 [details] [diff] [review]
patch

Review of attachment 8996167 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/172b93b2f600
Remove assertion that binary path matches between recording and replaying, r=mccr8.

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/172b93b2f600