Closed Bug 1479647 Opened 2 years ago Closed 2 years ago

Ensure that surface caches have consistent ordering between recording and replaying

Categories

(Core Graveyard :: Web Replay, defect)

defect
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Surface caches order their contents by the pointer addresses of the surfaces, which leads to different behavior when replaying a previous execution because pointer values differ from recording to replay.  This patch fixes the problem by including the results of the comparisons done while sorting in the recording.
Attachment #8996175 - Flags: review?(tnikkel)
Attachment #8996175 - Flags: review?(tnikkel) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93fea376b688
Ensure that surface caches have consistent ordering between recording and replaying, r=tnikkel.
https://hg.mozilla.org/mozilla-central/rev/93fea376b688
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.