Closed Bug 1479647 Opened 6 years ago Closed 6 years ago

Ensure that surface caches have consistent ordering between recording and replaying

Categories

(Core Graveyard :: Web Replay, defect)

Product:
Core Graveyard
Component:
Web Replay
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(1 file)

patch
723 bytes, patch
tnikkel
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
Surface caches order their contents by the pointer addresses of the surfaces, which leads to different behavior when replaying a previous execution because pointer values differ from recording to replay.  This patch fixes the problem by including the results of the comparisons done while sorting in the recording.
Attachment #8996175 - Flags: review?(tnikkel)
Attachment #8996175 - Flags: review?(tnikkel) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93fea376b688
Ensure that surface caches have consistent ordering between recording and replaying, r=tnikkel.
https://hg.mozilla.org/mozilla-central/rev/93fea376b688
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: