1479712 - Remove more JSAutoRealmAllowCCW uses in XPConnect

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P3)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1 - Require a plain function in xpcshell setInterruptCallback

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 2 - Remove unused nsIXPConnect.getWrappedNativePrototype

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 3 - Remove unnecessary AutoJSContext and JSAutoRealmAllowCCW in JSObject2NativeInterface and nsXPConnect::WrapJS

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Part 4 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in NativeInterface2JSObject

Comment 5

[Jan de Mooij [:jandem]]

This is green on (Linux64) Try. Part 3 could use a careful review, it's possible I'm missing something under JSObject2NativeInterface.

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Part 5 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in xpc::StackScopedClone

Comment 7

[Bobby Holley (:bholley)]

Comment on attachment 8996245 [details] [diff] [review]
Part 3 - Remove unnecessary AutoJSContext and JSAutoRealmAllowCCW in JSObject2NativeInterface and nsXPConnect::WrapJS

Review of attachment 8996245 [details] [diff] [review]:
-----------------------------------------------------------------

Note that these changes aren't as innocent as they seem, because instantiating an AutoJSContext and entering a compartment affects the subject principal, so things like nsContentUtils::IsCallerChrome() might return different results. That said, it looks like neither of these sites call into arbitrary stuff, so this should be ok. Just something to be aware of.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7acb1055fd98
part 1 - Require a plain function in xpcshell setInterruptCallback. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f054516b7bb
part 2 - Remove unused nsIXPConnect.getWrappedNativePrototype. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/368471d4f669
part 3 - Remove unnecessary AutoJSContext and JSAutoRealmAllowCCW in JSObject2NativeInterface and nsXPConnect::WrapJS. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8231fa203a9
part 4 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in NativeInterface2JSObject. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/43fb091672e7
part 5 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in xpc::StackScopedClone. r=bholley

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7acb1055fd98
https://hg.mozilla.org/mozilla-central/rev/7f054516b7bb
https://hg.mozilla.org/mozilla-central/rev/368471d4f669
https://hg.mozilla.org/mozilla-central/rev/e8231fa203a9
https://hg.mozilla.org/mozilla-central/rev/43fb091672e7