1479744 - Perma-fail [Test-Verfy] browser/base/content/test/about/browser_aboutHome_search_composing.js | waitForDocLoadAndStopIt: The expected URL was loaded - Got http://mochi.test:8888/?terms=xfoo, expected http://mochi.test:8888/?terms=xbar

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=191082205&repo=autoland

https://queue.taskcluster.net/v1/task/Yb05ZDcVTAmUSFkVyJ8DuQ/runs/0/artifacts/public/logs/live_backing.log

11:41:14     INFO - Entering test bound 
11:41:14     INFO - Clicking suggestion list while composing
11:41:14     INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/FileUtils.jsm" line: 170}]
11:41:14     INFO - Waiting for engine to be added: searchSuggestionEngine.xml
11:41:14     INFO - Search engine added: searchSuggestionEngine.xml
11:41:14     INFO - Console message: Security Error: Content at about:newtab may not load or link to chrome://mozapps/skin/places/defaultFavicon.svg.
11:41:14     INFO - Console message: Security Error: Content at about:newtab may not load or link to chrome://mozapps/skin/places/defaultFavicon.svg.
11:41:14     INFO - Console message: Security Error: Content at about:home may not load or link to chrome://mozapps/skin/places/defaultFavicon.svg.
11:41:14     INFO - Console message: Security Error: Content at about:home may not load or link to chrome://mozapps/skin/places/defaultFavicon.svg.
11:41:14     INFO - Setting up the mutation observer before synthesizing composition
11:41:14     INFO - Waiting for search suggestion table unhidden
11:41:14     INFO - TEST-PASS | browser/base/content/test/about/browser_aboutHome_search_composing.js | Search suggestion table unhidden - true == true - 
11:41:14     INFO - waitForDocLoadAndStopIt: Waiting for URL: http://mochi.test:8888/?terms=xbar
11:41:14     INFO - Buffered messages finished
11:41:14     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/about/browser_aboutHome_search_composing.js | waitForDocLoadAndStopIt: The expected URL was loaded - Got http://mochi.test:8888/?terms=xfoo, expected http://mochi.test:8888/?terms=xbar

Comment 1

[Intermittent Failures Robot]

17 failures in 134 pushes (0.127 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 11
* mozilla-central: 6

Platform breakdown:
* windows7-32: 5
* windows10-64: 5
* linux64: 3
* osx-10-10: 2
* windows7-32-msvc: 1
* windows10-64-msvc: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1479744&startday=2018-07-31&endday=2018-07-31&tree=trunk

Comment 2

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Comment 4

[Mark Banner (:standard8)]

Note: Still happens as per bug 1506814. Looks like an activity stream related test, that perma fails during test-verify.

Comment 5

[Andrei Oprea [:andreio]]

Attachment: grafik.png

Did some investigation and I think I know why this is happening: TV does multiple test runs sometimes without restarting the browser. The first time this runs it types "X" in the search bar and "xfoo" "xbar" show up as suggestions. Second time around the first suggestion will be "X" from the previous query/history so the index of the expected result is now at position + 1.

I could look into fixing this but I'm not sure the search component is part of AS (we haven't really worked on it) ni? Standard8 for a second opinion.

Comment 6

[Mark Banner (:standard8)]

Well the test was written by Ed, and its within the new tab, which is why I pushed it in this direction... though as you say it is search related as well...

Given what you've said, I think the test just needs to clean up after itself - i.e. remove the saved suggestions. I'm not sure if that's PlacesUtils.history.clear() or something else. Maybe Drew knows?

Comment 7

[Drew Willcoxon :adw]

Yeah, it does look like all you need is `await PlacesUtils.history.clear()`.  I would call clear() both before and after the the main part of the test, to make sure the test starts with a blank slate, and then to clean up after itself as Mark says.  I'm guessing if you pause the test the second time it runs, you'll see that the first result has a little clock icon, indicating that it came from history.

Comment 8

[Intermittent Failures Robot]

3 failures in 2808 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 3

Platform breakdown:
* windows10-64: 1
* windows7-32: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1479744&startday=2018-11-26&endday=2018-12-02&tree=all

Comment 9

[Andrei Oprea [:andreio]]

It seems like `history.clear()` does not remove local search history, I couldn't find anything explicit about this except [0]
There seem to be some ways to explicitly remove them [1] and [2] but I couldn't get it to remove the result so I am probably not using the correct API. Do you know more about this?

[0] https://searchfox.org/mozilla-central/rev/3fdc51e66c9487b39220ad58dcee275fca070ccd/toolkit/components/search/SearchSuggestionController.jsm#72
[1] https://searchfox.org/mozilla-central/rev/3fdc51e66c9487b39220ad58dcee275fca070ccd/browser/modules/ContentSearch.jsm#208
[2] https://searchfox.org/mozilla-central/rev/3fdc51e66c9487b39220ad58dcee275fca070ccd/browser/modules/test/browser/browser_ContentSearch.js#218

Comment 10

[Drew Willcoxon :adw]

You're right, this is form history, not browsing history, sorry.  It looks like you can remove all form history by calling FormHistory.update (in FormHistory.jsm) like this: https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/browser/base/content/test/sanitize/browser_sanitize-formhistory.js#9

It's implemented here, in case it helps: https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/toolkit/components/satchel/FormHistory.jsm#954

Comment 11

[Andrei Oprea [:andreio]]

Attachment: Bug 1479744 - Clear search history to prevent TV perma fail for browser/base/content/test/about/browser_aboutHome_search_composing.js

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da8b6bcd0deb
Clear search history to prevent TV perma fail for browser/base/content/test/about/browser_aboutHome_search_composing.js r=adw

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/da8b6bcd0deb